Bugzilla – Attachment 78052 Details for
Bug 7996
Patron modification log requires parameters permission
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 7996: Correct wrong permissions for modification log
Bug-7996-Correct-wrong-permissions-for-modificatio.patch (text/plain), 3.61 KB, created by
Katrin Fischer
on 2018-08-21 20:18:07 UTC
(
hide
)
Description:
Bug 7996: Correct wrong permissions for modification log
Filename:
MIME Type:
Creator:
Katrin Fischer
Created:
2018-08-21 20:18:07 UTC
Size:
3.61 KB
patch
obsolete
>From 2b6d6a103efe76108610f355bc6f68dd62b602b6 Mon Sep 17 00:00:00 2001 >From: Nick Clemens <nick@bywatersolutions.com> >Date: Fri, 17 Aug 2018 11:07:41 +0000 >Subject: [PATCH] Bug 7996: Correct wrong permissions for modification log > >To test: > 1 - Create a staff patron with catalogue,borrowers,and view_system_logs > permissions > 2 - Log in using that patron > 3 - Go to tools > 4 - Click 'Log viewer' > 5 - You get a blank page > 6 - View borrower circ screen, note you do not see 'Modification log' > 7 - Edit a borrower, note you do not see 'Modification log' > 8 - Apply patch > 9 - 'Log Viewer' should now load correctly >10 - You should see 'Modification log' tab during circ >11 - You should see 'Modification log' tab when editing patron > >Signed-off-by: Owen Leonard <oleonard@myacpl.org> > >Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> >--- > koha-tmpl/intranet-tmpl/prog/en/includes/circ-menu.inc | 2 +- > koha-tmpl/intranet-tmpl/prog/en/includes/members-menu.inc | 2 +- > koha-tmpl/intranet-tmpl/prog/en/modules/tools/viewlog.tt | 2 +- > 3 files changed, 3 insertions(+), 3 deletions(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/includes/circ-menu.inc b/koha-tmpl/intranet-tmpl/prog/en/includes/circ-menu.inc >index 03cc9a7..a69d099 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/includes/circ-menu.inc >+++ b/koha-tmpl/intranet-tmpl/prog/en/includes/circ-menu.inc >@@ -97,7 +97,7 @@ > [% IF ( holdshistoryview ) %]<li class="active">[% ELSE %]<li>[% END %]<a href="/cgi-bin/koha/members/holdshistory.pl?borrowernumber=[% patron.borrowernumber | html %]">Holds history</a></li> > [% END %] > [% END %] >- [% IF ( CAN_user_parameters ) %] >+ [% IF ( CAN_user_tools_view_system_logs ) %] > [% IF ( logview ) %]<li class="active">[% ELSE %]<li>[% END %]<a href="/cgi-bin/koha/tools/viewlog.pl?do_it=1&modules=MEMBERS&modules=circulation&object=[% patron.borrowernumber | html %]&src=circ">Modification log</a></li> > [% END %] > [% IF CAN_user_borrowers_edit_borrowers %] >diff --git a/koha-tmpl/intranet-tmpl/prog/en/includes/members-menu.inc b/koha-tmpl/intranet-tmpl/prog/en/includes/members-menu.inc >index d7d08b5..190bd4f 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/includes/members-menu.inc >+++ b/koha-tmpl/intranet-tmpl/prog/en/includes/members-menu.inc >@@ -9,7 +9,7 @@ > [% IF ( intranetreadinghistory ) %] > [% IF ( readingrecordview ) %]<li class="active">[% ELSE %]<li>[% END %]<a href="/cgi-bin/koha/members/readingrec.pl?borrowernumber=[% borrowernumber | html %]">Circulation history</a></li> > [% END %] >- [% IF ( CAN_user_parameters ) %] >+ [% IF ( CAN_user_tools_view_system_logs ) %] > [% IF ( logview ) %]<li class="active">[% ELSE %]<li>[% END %]<a href="/cgi-bin/koha/tools/viewlog.pl?do_it=1&modules=MEMBERS&action=MODIFY&object=[% borrowernumber | html %]">Modification log</a></li> > [% END %] > [% IF ( sentnotices ) %]<li class="active">[% ELSE %]<li>[% END %]<a href="/cgi-bin/koha/members/notices.pl?borrowernumber=[% borrowernumber | html %]">Notices</a></li> >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/tools/viewlog.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/tools/viewlog.tt >index 2656d96..d1df207 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/tools/viewlog.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/tools/viewlog.tt >@@ -81,7 +81,7 @@ > <div id="bd"> > <div id="yui-main"> > <div class="yui-b"> >- [% IF ( CAN_user_reports ) %] >+ [% IF ( CAN_user_tools_view_system_logs ) %] > <h1>Browse system logs</h1> > <form method="post" action="/cgi-bin/koha/tools/viewlog.pl"> > [% IF ( do_it ) %] >-- >2.1.4
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 7996
:
9274
|
9275
|
35262
|
77974
|
77991
|
77993
| 78052 |
78053