Attachment 78061 Details for Bug 21239 – Bug 21239: CSS regressions caused by SCSS move

[patch] Bug 21239: CSS regressions caused by SCSS move

Bug-21239-CSS-regressions-caused-by-SCSS-move.patch (text/plain), 2.09 KB, created by Jonathan Druart on 2018-08-22 00:30:52 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Jonathan Druart

Created: 2018-08-22 00:30:52 UTC

Size: 2.09 KB

patch

obsolete

>From 1bd28c2a7dbfb220d0fb69f4faf2e0440bd7ef21 Mon Sep 17 00:00:00 2001
>From: Owen Leonard <oleonard@myacpl.org>
>Date: Fri, 17 Aug 2018 12:47:52 +0000
>Subject: [PATCH] Bug 21239: CSS regressions caused by SCSS move
>
>This patch corrects some mistakes in staff-global.scss made during the
>conversion from CSS.
>
>To test, apply the patch and regenerate your CSS
>(https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_client).
>Clear your browser cache if necessary.
>
>View various forms in the staff client which have hints and required
>fields, including:
>
>- Notices & slips -> Modify notice
>- Administration -> Budgets -> Modify budget
>
>Verify that date format hints are positioned correctly. Try to submit
>the form with empty required fields and verify that the "This field is
>required" message is positioned correctly.
>
>Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
>---
> koha-tmpl/intranet-tmpl/prog/css/src/staff-global.scss | 10 +++++-----
> 1 file changed, 5 insertions(+), 5 deletions(-)
>
>diff --git a/koha-tmpl/intranet-tmpl/prog/css/src/staff-global.scss b/koha-tmpl/intranet-tmpl/prog/css/src/staff-global.scss
>index 5e3d2891c3..2fc5b84410 100644
>--- a/koha-tmpl/intranet-tmpl/prog/css/src/staff-global.scss
>+++ b/koha-tmpl/intranet-tmpl/prog/css/src/staff-global.scss
>@@ -895,7 +895,7 @@ fieldset {
>         border: 2px solid #B9D8D9;
> 
>         div {
>-            .hint {
>+            &.hint {
>                 margin-bottom: .4em;
>             }
>         }
>@@ -1010,9 +1010,9 @@ fieldset {
>         }
> 
>         div {
>-            .hint {
>+            &.hint {
>                 margin-bottom: .4em;
>-                margin-left: 7.5em;
>+                margin-left: 10.5em;
>             }
>         }
> 
>@@ -1120,7 +1120,7 @@ fieldset {
>                 font-weight: bold;
>                 margin-right: 1em;
>                 text-align: right;
>-                width: 6em;
>+                width: 9em;
>             }
>         }
> 
>@@ -1167,7 +1167,7 @@ fieldset {
> 
> .yui-u {
>     div {
>-        .hint {
>+        &.hint {
>             margin-bottom: .4em;
>         }
>     }
>-- 
>2.11.0

Actions: View | Diff | Splinter Review

Attachments on bug 21239: 77978 | 77985 | 78061 | 78102