Bugzilla – Attachment 78113 Details for
Bug 21184
C4::Items - Remove GetBarcodeFromItemnumber
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 21184: (follow-up) Fix adding barcode to waiting hold item in SIP
Bug-21184-follow-up-Fix-adding-barcode-to-waiting-.patch (text/plain), 1.66 KB, created by
Marcel de Rooy
on 2018-08-24 08:17:04 UTC
(
hide
)
Description:
Bug 21184: (follow-up) Fix adding barcode to waiting hold item in SIP
Filename:
MIME Type:
Creator:
Marcel de Rooy
Created:
2018-08-24 08:17:04 UTC
Size:
1.66 KB
patch
obsolete
>From 381263fbd4491a82cbac0a796c0b2c34c292f305 Mon Sep 17 00:00:00 2001 >From: Josef Moravec <josef.moravec@gmail.com> >Date: Fri, 17 Aug 2018 05:26:57 +0000 >Subject: [PATCH] Bug 21184: (follow-up) Fix adding barcode to waiting hold > item in SIP >Content-Type: text/plain; charset=utf-8 > >Test plan: >1) Set up your SIP: https://wiki.koha-community.org/wiki/Koha_SIP2_server_setup >2) Run: >misc/sip_cli_emulator.pl -a localhost -p 6001 -su <login> -sp <passsword> -l <library_code> --patron <borrowernumber> -s "Y " -m patron_information > >the -s parameter says what kind of additional information you want to see > >3) Check the response: if the requested patron has waiting hold, there >is field "AS" with the barcode of waiting item > >The right response looks like this: >64 00120180817 >052434000100000000000000000000AOCPL|AA1|AEKoha Admin|BLY|CC5|AS39999000004410|PCS|PIY|AFGreetings from Koha. | > >More reading ;) >http://multimedia.3m.com/mws/media/355361O/sip2-protocol.pdf > >Signed-off-by: Josef Moravec <josef.moravec@gmail.com> > >Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> >--- > C4/SIP/ILS/Patron.pm | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > >diff --git a/C4/SIP/ILS/Patron.pm b/C4/SIP/ILS/Patron.pm >index 41c21a1..3d9de0d 100644 >--- a/C4/SIP/ILS/Patron.pm >+++ b/C4/SIP/ILS/Patron.pm >@@ -317,7 +317,7 @@ sub hold_items { > my $item_arr = $self->x_items('hold_items', @_); > foreach my $item (@{$item_arr}) { > my $item_obj = Koha::Items->find($item->{itemnumber}); >- $item_arr->{barcode} = $item_obj ? $item_obj->barcode : undef; >+ $item->{barcode} = $item_obj ? $item_obj->barcode : undef; > } > return $item_arr; > } >-- >2.1.4
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 21184
:
77589
|
77590
|
77955
|
77956
|
77961
|
77962
|
77963
|
78111
|
78112
| 78113