Bugzilla – Attachment 78137 Details for
Bug 15524
Set limit on maximum possible holds per patron by category
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 15524: (QA follow-up) Pass max_holds at the right position in update
Bug-15524-QA-follow-up-Pass-maxholds-at-the-right-.patch (text/plain), 1.17 KB, created by
Nick Clemens (kidclamp)
on 2018-08-24 15:16:17 UTC
(
hide
)
Description:
Bug 15524: (QA follow-up) Pass max_holds at the right position in update
Filename:
MIME Type:
Creator:
Nick Clemens (kidclamp)
Created:
2018-08-24 15:16:17 UTC
Size:
1.17 KB
patch
obsolete
>From c3d24d38eb65047b85de818511e5fa22873cd537 Mon Sep 17 00:00:00 2001 >From: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> >Date: Fri, 16 Feb 2018 12:12:12 +0100 >Subject: [PATCH] Bug 15524: (QA follow-up) Pass max_holds at the right > position in update > >When updating max_holds should be before the categorycode in the update >query. >Things that can be found by testing :) > >Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> >--- > admin/smart-rules.pl | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > >diff --git a/admin/smart-rules.pl b/admin/smart-rules.pl >index 1279c4a..eb4ef7b 100755 >--- a/admin/smart-rules.pl >+++ b/admin/smart-rules.pl >@@ -306,7 +306,7 @@ elsif ($op eq "add-branch-cat") { > $sth_search->execute($categorycode); > my $res = $sth_search->fetchrow_hashref(); > if ($res->{total}) { >- $sth_update->execute( $maxissueqty, $maxonsiteissueqty, $categorycode, $max_holds ); >+ $sth_update->execute( $maxissueqty, $maxonsiteissueqty, $max_holds, $categorycode ); > } else { > $sth_insert->execute( $categorycode, $maxissueqty, $maxonsiteissueqty, $max_holds ); > } >-- >2.1.4
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 15524
:
64707
|
64708
|
67180
|
67181
|
67531
|
70389
|
70390
|
70391
|
70392
|
71704
|
71705
|
71706
|
71737
|
71738
|
71739
|
71740
|
71741
|
77648
|
77681
|
77682
|
78134
|
78135
|
78136
| 78137 |
78138
|
78139
|
78140