Attachment 78164 Details for Bug 7534 – Bug 7534: Display pickup locations instead of all libraries in request.pl

[patch] Bug 7534: Display pickup locations instead of all libraries in request.pl

Bug-7534-Display-pickup-locations-instead-of-all-l.patch (text/plain), 2.14 KB, created by Nick Clemens (kidclamp) on 2018-08-25 19:08:19 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Nick Clemens (kidclamp)

Created: 2018-08-25 19:08:19 UTC

Size: 2.14 KB

patch

obsolete

>From ca66d056861fbc0de698bc9ceb9c64393d449c05 Mon Sep 17 00:00:00 2001
>From: Lari Taskula <lari.taskula@jns.fi>
>Date: Wed, 8 Feb 2017 16:45:23 +0200
>Subject: [PATCH] Bug 7534: Display pickup locations instead of all libraries
> in request.pl
>
>This patch sets request.tt to use the list of pickup libraries instead
>of every library in the system.
>
>To test:
>1. Go to cgi-bin/koha/admin/branches.pl
>2. Configure one of your libraries to "Pickup location" => "No"
>3. Go place a hold in intranet
>4. See the provided "Pickup at" list
>5. Observe the library that you configured is not present in the list
>6. Place the hold
>7. See list of existing holds on that biblio
>8. See "Pickup library" column and observe your configured library is
>   not included in the list
>
>Signed-off-by: Koha Team AMU <axelle.clarisse@univ-amu.fr>
>---
> koha-tmpl/intranet-tmpl/prog/en/modules/reserve/request.tt | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/reserve/request.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/reserve/request.tt
>index 212c205..7d8276e 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/reserve/request.tt
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/reserve/request.tt
>@@ -198,7 +198,7 @@
>         <li>
>             <label for="pickup">Pickup at:</label>
>             <select name="pickup" size="1" id="pickup">
>-                [% PROCESS options_for_libraries libraries => Branches.all() %]
>+                [% PROCESS options_for_libraries libraries => Branches.all({ search_params => { pickup_location => 1 } }) %]
>             </select>
>         </li>
> 
>@@ -615,7 +615,7 @@
>             [% Branches.GetName(reserveloo.branchcode) | html %] <input type="hidden" name="pickup" value="[% reserveloo.branchcode | html %]" />
>         [% ELSE %]
>             <select name="pickup">
>-                [% PROCESS options_for_libraries libraries => Branches.all( selected => reserveloo.branchcode ) %]
>+                [% PROCESS options_for_libraries libraries => Branches.all({ search_params => { pickup_location => 1 }, selected => reserveloo.branchcode }) %]
>             </select>
>         [% END %]
>     [% END %]
>-- 
>2.1.4

Actions: View | Diff | Splinter Review

Attachments on bug 7534: 60014 | 60015 | 60016 | 60017 | 60018 | 60022 | 60023 | 60781 | 60794 | 60795 | 60796 | 60797 | 60798 | 60799 | 60878 | 60879 | 60880 | 60881 | 60882 | 60883 | 61044 | 61045 | 61046 | 61047 | 61273 | 61274 | 61275 | 61276 | 61277 | 61278 | 61279 | 61280 | 77847 | 77848 | 77849 | 77850 | 77851 | 77852 | 77853 | 77854 | 77855 | 77856 | 78160 | 78161 | 78162 | 78163 | 78164 | 78165 | 78166 | 78167 | 78168 | 78169 | 78170 | 78171 | 78477 | 78478 | 78479 | 78480 | 78481 | 78482 | 78483 | 78484 | 78485 | 78486 | 78487 | 78488 | 78489 | 78495 | 78540 | 78548 | 84852