Attachment 78166 Details for Bug 7534 – Bug 7534: (QA-follow-up) Default pickup location to Yes when adding a new library

[patch] Bug 7534: (QA-follow-up) Default pickup location to Yes when adding a new library

Bug-7534-QA-follow-up-Default-pickup-location-to-Y.patch (text/plain), 2.61 KB, created by Nick Clemens (kidclamp) on 2018-08-25 19:08:29 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Nick Clemens (kidclamp)

Created: 2018-08-25 19:08:29 UTC

Size: 2.61 KB

patch

obsolete

>From 51c2cf368341c9f3c56d5fe67526305ecccfa47e Mon Sep 17 00:00:00 2001
>From: Lari Taskula <lari.taskula@jns.fi>
>Date: Tue, 7 Mar 2017 17:38:28 +0200
>Subject: [PATCH] Bug 7534: (QA-follow-up) Default pickup location to Yes when
> adding a new library
>
>To test:
>1. Apply the patches before this one
>2. Go to /cgi-bin/koha/admin/branches.pl
>3. Press New library button
>4. Scroll down the page and observe Pickup location defaults to No
>5. Apply this patch
>6. Go to /cgi-bin/koha/admin/branches.pl
>7. Press New library button
>8. Scroll down the page and observe Pickup location now defaults to Yes
>
>Signed-off-by: Koha Team AMU <axelle.clarisse@univ-amu.fr>
>---
> koha-tmpl/intranet-tmpl/prog/en/modules/admin/branches.tt | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/branches.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/branches.tt
>index 5db78ed..fade9ce 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/branches.tt
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/branches.tt
>@@ -147,7 +147,7 @@
>                 <li><label for="branchip">IP: </label><input type="text" name="branchip" id="branchip"  size="15" maxlength="15" value="[% library.branchip | html %]" /> <span class="hint">Can be entered as a single IP, or a subnet such as 192.168.1.*</span></li>
>                 <li><label for="marcorgccode">MARC organization code</label> <input type="text" name="marcorgcode" id="marcorgcode" size="16" value="[% library.marcorgcode | html %]" /> <span class="hint">If not filled in defaults to system preference MARCOrgCode. You can obtain your code from <a href="http://www.loc.gov/marc/organizations/orgshome.html" target="_blank">Library of Congress</a>.</span>
>                 <li><label for="branchnotes">Notes: </label><input type="text" name="branchnotes" id="branchnotes" size="80" value="[% library.branchnotes | html %]" /></li>
>-                <li><label for="pickup_location">Pickup location: </label><select name="pickup_location" id="pickup_location"><option value="1" [% IF library.pickup_location %]selected[% END %]>Yes</option><option value="0" [% IF !library.pickup_location %]selected[% END %]>No</option></select></li>
>+                <li><label for="pickup_location">Pickup location: </label><select name="pickup_location" id="pickup_location"><option value="1" [% IF !library || library.pickup_location == 1 %]selected="selected"[% END %]>Yes</option><option value="0" [% IF library && library.pickup_location == 0 %]selected="selected"[% END %]>No</option></select></li>
>             </ol>
>         </fieldset>
>         <fieldset class="action">
>-- 
>2.1.4

Actions: View | Diff | Splinter Review

Attachments on bug 7534: 60014 | 60015 | 60016 | 60017 | 60018 | 60022 | 60023 | 60781 | 60794 | 60795 | 60796 | 60797 | 60798 | 60799 | 60878 | 60879 | 60880 | 60881 | 60882 | 60883 | 61044 | 61045 | 61046 | 61047 | 61273 | 61274 | 61275 | 61276 | 61277 | 61278 | 61279 | 61280 | 77847 | 77848 | 77849 | 77850 | 77851 | 77852 | 77853 | 77854 | 77855 | 77856 | 78160 | 78161 | 78162 | 78163 | 78164 | 78165 | 78166 | 78167 | 78168 | 78169 | 78170 | 78171 | 78477 | 78478 | 78479 | 78480 | 78481 | 78482 | 78483 | 78484 | 78485 | 78486 | 78487 | 78488 | 78489 | 78495 | 78540 | 78548 | 84852