Attachment 7822 Details for Bug 7582 – [SIGNED-OFF] Bug 7582 - When adding a Z39.50 server the "checked" option should use a Yes/No dropdown

[patch] [SIGNED-OFF] Bug 7582 - When adding a Z39.50 server the "checked" option should use a Yes/No dropdown

0001-Bug-7582-When-adding-a-Z39.50-server-the-checked-opt.patch (text/plain), 4.66 KB, created by Jonathan Druart on 2012-02-23 10:08:00 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Jonathan Druart

Created: 2012-02-23 10:08:00 UTC

Size: 4.66 KB

patch

obsolete

>From 99f54cc8439501169b2ea4945cf85eb0ebbaa11d Mon Sep 17 00:00:00 2001
>From: Owen Leonard <oleonard@myacpl.org>
>Date: Wed, 22 Feb 2012 12:24:54 -0500
>Subject: [PATCH 1/1] Bug 7582 - When adding a Z39.50 server the "checked"
> option should use a Yes/No dropdown
>
>Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
>---
> .../prog/en/modules/admin/z3950servers.tt          |   65 +++++++++++++++-----
> 1 files changed, 50 insertions(+), 15 deletions(-)
>
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/z3950servers.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/z3950servers.tt
>index e565acf..2577b0c 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/z3950servers.tt
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/z3950servers.tt
>@@ -109,7 +109,17 @@
> 		</li>
> 		<li><label for="password">Password: </label>	<input type="text" name="password" id="password" value="[% password %]" />
> 		</li>
>-		<li><label for="checked">Checked (searched by default): </label>	<input type="text" size="1" name="checked" id="checked" value="[% checked %]" onblur="isNum(this)" />  </li>
>+		<li><label for="checked">Checked (searched by default): </label>
>+                        <select name="checked" id="checked">
>+                                [% IF ( checked ) %]
>+                                        <option value="0">No</option>
>+                                        <option value="1" selected="selected">Yes</option>
>+                                [% ELSE %]
>+                                        <option value="0" selected="selected">No</option>
>+                                        <option value="1">Yes</option>
>+                                [% END %]
>+                        </select>
>+                </li>
> 		<li><label for="rank">Rank (display order): </label>	<input type="text" name="rank" id="rank" size="4" value="[% rank %]" onblur="isNum(this)" />
> 		</li>	
> 		<li><label for="syntax">Syntax (z3950 can send<br /> records in various format. Choose one): </label>	
>@@ -293,21 +303,46 @@
> 
> <h3>Z39.50 Servers Administration</h3>
> 
>-        [% IF ( searchfield ) %]
>-                You searched for [% searchfield %]
>-        [% END %]		
>+[% IF ( searchfield ) %]
>+        You searched for [% searchfield %]
>+[% END %]
> <table id="serverst">
>-                <thead><tr><th>Target</th><th>Hostname/Port</th><th>Database</th><th>Userid</th><th>Password</th><th>Checked</th><th>Rank</th>       			<th>Syntax</th><th>Encoding</th><th colspan="2">&nbsp;</th>
>-                </tr></thead>
>-                <tbody>[% FOREACH loo IN loop %]
>-                [% UNLESS ( loop.odd ) %]
>-                    <tr class="highlight">
>-                [% ELSE %]
>-                    <tr>
>-                [% END %]
>-<td><a href="[% loo.script_name %]?op=add_form&amp;searchfield=[% loo.name |url %]">[% loo.name %]</a></td><td>[% loo.host %]:[% loo.port %]</td><td>[% loo.db %]</td><td>[% loo.userid %]</td><td>[% loo.password %]</td><td>[% loo.checked %]</td><td>[% loo.rank %]</td>			<td>[% loo.syntax %]</td><td>[% loo.encoding %]</td><td><a href="[% loo.script_name %]?op=add_form&amp;searchfield=[% loo.name |url %]">Edit</a></td><td><a href="[% loo.script_name %]?op=delete_confirm&amp;searchfield=[% loo.name |url %]">Delete</a></td>                </tr>
>-                [% END %]</tbody>
>-	</table>
>+   <thead>
>+       <tr>
>+           <th>Target</th>
>+           <th>Hostname/Port</th>
>+           <th>Database</th>
>+           <th>Userid</th>
>+           <th>Password</th>
>+           <th>Checked</th>
>+           <th>Rank</th>
>+           <th>Syntax</th>
>+           <th>Encoding</th>
>+           <th colspan="2">&nbsp;</th>
>+       </tr>
>+   </thead>
>+   <tbody>
>+   [% FOREACH loo IN loop %]
>+       [% UNLESS ( loop.odd ) %]
>+           <tr class="highlight">
>+       [% ELSE %]
>+           <tr>
>+       [% END %]
>+           <td><a href="[% loo.script_name %]?op=add_form&amp;searchfield=[% loo.name |url %]">[% loo.name %]</a></td>
>+           <td>[% loo.host %]:[% loo.port %]</td>
>+           <td>[% loo.db %]</td>
>+           <td>[% loo.userid %]</td>
>+           <td>[% loo.password %]</td>
>+           <td>[% IF ( loo.checked ) %]Yes[% ELSE %]No[% END %]</td>
>+           <td>[% loo.rank %]</td>
>+           <td>[% loo.syntax %]</td>
>+           <td>[% loo.encoding %]</td>
>+           <td><a href="[% loo.script_name %]?op=add_form&amp;searchfield=[% loo.name |url %]">Edit</a></td>
>+           <td><a href="[% loo.script_name %]?op=delete_confirm&amp;searchfield=[% loo.name |url %]">Delete</a></td>
>+       </tr>
>+   [% END %]
>+   </tbody>
>+</table>
> 
> [% IF ( offsetgtzero ) %]<form action="[% script_name %]" method="get">
> 	<input type="hidden" name="offset" value="[% prevpage %]" />
>-- 
>1.7.7.3
>

Actions: View | Diff | Splinter Review

Attachments on bug 7582: 7813 | 7822 | 7854 | 7872