Bugzilla – Attachment 78320 Details for
Bug 21205
C4::Acquisition - Remove GetOrderFromItemnumber
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 21205: (follow-up) Fix column name - itemnumbers -> itemnumber
Bug-21205-follow-up-Fix-column-name---itemnumbers-.patch (text/plain), 2.25 KB, created by
Marcel de Rooy
on 2018-08-31 05:46:32 UTC
(
hide
)
Description:
Bug 21205: (follow-up) Fix column name - itemnumbers -> itemnumber
Filename:
MIME Type:
Creator:
Marcel de Rooy
Created:
2018-08-31 05:46:32 UTC
Size:
2.25 KB
patch
obsolete
>From 9aeb7158d9399b10ea3ac6ce3860648f89fd1c1a Mon Sep 17 00:00:00 2001 >From: Josef Moravec <josef.moravec@gmail.com> >Date: Tue, 21 Aug 2018 13:16:02 +0000 >Subject: [PATCH] Bug 21205: (follow-up) Fix column name - itemnumbers -> > itemnumber >Content-Type: text/plain; charset=utf-8 > >Signed-off-by: Josef Moravec <josef.moravec@gmail.com> > >Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> >--- > acqui/orderreceive.pl | 2 +- > acqui/parcel.pl | 4 ++-- > 2 files changed, 3 insertions(+), 3 deletions(-) > >diff --git a/acqui/orderreceive.pl b/acqui/orderreceive.pl >index 6f04257..facd3d0 100755 >--- a/acqui/orderreceive.pl >+++ b/acqui/orderreceive.pl >@@ -128,7 +128,7 @@ if ($AcqCreateItem eq 'receiving') { > ); > } elsif ($AcqCreateItem eq 'ordering') { > my $fw = ($acq_fw) ? 'ACQ' : ''; >- my @itemnumbers = $order_object->items->get_column('itemnumbers'); >+ my @itemnumbers = $order_object->items->get_column('itemnumber'); > my @items; > foreach (@itemnumbers) { > my $item = GetItem($_); # FIXME We do not need this call, we already have the Koha::Items >diff --git a/acqui/parcel.pl b/acqui/parcel.pl >index da0b4cf..da06003 100755 >--- a/acqui/parcel.pl >+++ b/acqui/parcel.pl >@@ -140,7 +140,7 @@ for my $order ( @orders ) { > > my %line = %{ $order }; > $line{invoice} = $invoice->{invoicenumber}; >- my @itemnumbers = $order_object->items->get_column('itemnumbers'); >+ my @itemnumbers = $order_object->items->get_column('itemnumber'); > my $biblio = Koha::Biblios->find( $line{biblionumber} ); > $line{total_holds} = $biblio ? $biblio->holds->count : 0; > $line{item_holds} = $biblio ? $biblio->current_holds->search( >@@ -247,7 +247,7 @@ unless( defined $invoice->{closedate} ) { > my $cnt_subscriptions = $biblio ? $biblio->subscriptions->count: 0; > my $itemcount = $biblio ? $biblio->items->count : 0; > my $holds_count = $biblio ? $biblio->holds->count : 0; >- my @itemnumbers = $order_object->items->get_column('itemnumbers'); >+ my @itemnumbers = $order_object->items->get_column('itemnumber'); > my $itemholds = $biblio ? $biblio->holds->search({ itemnumber => { -in => \@itemnumbers } })->count : 0; > > my $suggestion = GetSuggestionInfoFromBiblionumber($line{biblionumber}); >-- >2.1.4
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 21205
:
77698
|
78042
|
78043
|
78319
| 78320