Attachment 78425 Details for Bug 15565 – Bug 15565: Changed the retrieval of selected hold pickup branch in opac-reserve.pl

[patch] Bug 15565: Changed the retrieval of selected hold pickup branch in opac-reserve.pl

Bug-15565-Changed-the-retrieval-of-selected-hold-p.patch (text/plain), 2.29 KB, created by Alex Buckley on 2018-09-04 21:14:40 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Alex Buckley

Created: 2018-09-04 21:14:40 UTC

Size: 2.29 KB

patch

obsolete

>From 5a4481b2161d724604fe891629a456a17839bd80 Mon Sep 17 00:00:00 2001
>From: Alex Buckley <alexbuckley@catalyst.net.nz>
>Date: Wed, 29 Aug 2018 23:07:24 +1200
>Subject: [PATCH] Bug 15565: Changed the retrieval of selected hold pickup
> branch in opac-reserve.pl
>
>Previously the selected branch dropdown value was not being successfully retrieved in
>opac-reserve.pl, this resulted in opac holds being placed with no pickup
>branch being set.
>
>Consequently as no branch was associated with the hold an Ajax error was
>thrown when viewing the holds-table in the patron page in the staff
>client.
>
>This commit successfully retrieves the selected branch value and so
>fixing the Ajax error.
>
>Test plan:
>1. Apply all patches on bug report 15565 except this commit
>
>2. Place a hold(s) from opac-reserve.pl.
>
>3. Go to your opac patron summary page (opac-user.pl) and notice
>although the holds are successfully displayed they have no 'Pickup
>location' value
>
>4. Go to the patron page in the staff client and click on the 'Hold(s)'
>tab and notice a popup explaining the datatable Ajax error is loaded
>
>5. Apply this patch
>
>6. Repeat step 3 noticing this time in the
>opac-user.pl a 'Pickup location' is displayed for the hold you just
>created.
>
>6. Repeat step 4 and notice the hold datatable is successfully loaded
>and populated without an Ajax error popup being loaded.
>
>Sponsored-By: Brimbank Library
>---
> opac/opac-reserve.pl | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
>diff --git a/opac/opac-reserve.pl b/opac/opac-reserve.pl
>index afdaae5..ce424b2 100755
>--- a/opac/opac-reserve.pl
>+++ b/opac/opac-reserve.pl
>@@ -195,9 +195,8 @@ if ( $query->param('place_reserve') ) {
>     foreach my $biblioNum (@biblionumbers) {
>         my $itemNum = $query->param("checkitem_$biblioNum");
>         my @itemnumbers = $query->param("checkitem_$biblioNum");
>-        my $branch = $query->param("branch_$biblioNum");
>+        my $branch = $query->param("branch");
>         my $reqtype = $query->param("reqtype_$biblioNum");
>-        warn $biblioNum;
>         if (!$reqtype) {
>             #If no $reqtype value has been passed from the form this means both reqany and reqspecific radio buttons are disabled because a hold has been placed on this biblio previously and so a forced_hold_level exists.
>             # Determine what the forced_hold_level is.
>-- 
>2.1.4

Actions: View | Diff | Splinter Review

Attachments on bug 15565: 47527 | 47551 | 47552 | 50068 | 50069 | 50392 | 50393 | 56229 | 56230 | 56231 | 56232 | 56458 | 56510 | 56511 | 56512 | 56513 | 56514 | 56515 | 56517 | 56518 | 56519 | 56520 | 56521 | 56522 | 56523 | 56524 | 61244 | 61245 | 61246 | 61247 | 61248 | 61576 | 61577 | 61578 | 61579 | 61580 | 64590 | 64591 | 64592 | 64593 | 64594 | 66594 | 66595 | 66596 | 66597 | 66598 | 68759 | 68760 | 68761 | 68762 | 68763 | 71643 | 71644 | 71645 | 71646 | 71647 | 71648 | 72644 | 72645 | 72646 | 72647 | 72648 | 72649 | 78242 | 78243 | 78244 | 78245 | 78246 | 78247 | 78248 | 78266 | 78305 | 78417 | 78418 | 78419 | 78420 | 78421 | 78422 | 78423 | 78424 | 78425 | 78426 | 78712 | 78713 | 78714 | 78715 | 78716 | 78717 | 78718 | 78719 | 78720 | 78815 | 78816 | 78817 | 78818 | 78819 | 78820 | 78821 | 78822 | 78823 | 81419 | 81420 | 81421 | 81422 | 81423 | 81424 | 81425 | 81426 | 81427 | 81431 | 81449 | 81570 | 81571 | 81572 | 81573 | 81574 | 81575 | 81576 | 81577 | 81578 | 81579 | 81580 | 81581 | 82205 | 82206 | 82207 | 82208 | 82209 | 82210 | 82211 | 82212 | 82213 | 82214 | 82215 | 82216 | 82220 | 82221 | 83331 | 83332 | 83333 | 83334 | 83335 | 83336 | 83337 | 83338 | 83339 | 83340 | 83341 | 83342 | 83378 | 83380 | 83381 | 84541 | 84542 | 84543 | 84544 | 84545 | 84546 | 84547 | 84548 | 84549 | 84550 | 84551 | 84552 | 84553 | 87979 | 87980 | 87981 | 87982 | 87983 | 87984 | 87985 | 87986 | 87987 | 87988 | 87989 | 87990 | 87991 | 117128 | 117129 | 117130 | 117131 | 117132 | 117133 | 120365 | 120366 | 120367 | 120639 | 120640 | 120641 | 121941 | 122098 | 162071 | 162072 | 162073 | 162074 | 163052 | 163053 | 163054 | 163055 | 163092 | 163093 | 166005 | 166006 | 166007 | 166008 | 166009