Attachment 78441 Details for Bug 20600 – Bug 20600: (follow-up) Do not use $_ in loop

[patch] Bug 20600: (follow-up) Do not use $_ in loop

Bug-20600-follow-up-Do-not-use--in-loop.patch (text/plain), 1.13 KB, created by Andrew Isherwood on 2018-09-05 15:51:05 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Andrew Isherwood

Created: 2018-09-05 15:51:05 UTC

Size: 1.13 KB

patch

obsolete

>From 0118cf67f527e062ba2387d700ec8e73e8e8970a Mon Sep 17 00:00:00 2001
>From: Andrew Isherwood <andrew.isherwood@ptfs-europe.com>
>Date: Fri, 1 Jun 2018 11:59:35 +0100
>Subject: [PATCH] Bug 20600: (follow-up) Do not use $_ in loop
>
>Signed-off-by: Owen Leonard <oleonard@myacpl.org>
>---
> Koha/REST/V1/Illrequests.pm | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
>diff --git a/Koha/REST/V1/Illrequests.pm b/Koha/REST/V1/Illrequests.pm
>index 2a41987fb2..92d0bf6722 100644
>--- a/Koha/REST/V1/Illrequests.pm
>+++ b/Koha/REST/V1/Illrequests.pm
>@@ -66,11 +66,11 @@ sub list {
> 
>     # Create new "formatted" columns for each date column
>     # that needs formatting
>-    foreach(@req_list) {
>+    foreach my $req(@req_list) {
>         foreach my $field(@format_dates) {
>-            if (defined $_->{$field}) {
>-                $_->{$field . "_formatted"} = format_sqldatetime(
>-                    $_->{$field},
>+            if (defined $req->{$field}) {
>+                $req->{$field . "_formatted"} = format_sqldatetime(
>+                    $req->{$field},
>                     undef,
>                     undef,
>                     1
>-- 
>2.11.0

Actions: View | Diff | Splinter Review

Attachments on bug 20600: 74640 | 74641 | 75202 | 75276 | 75734 | 75735 | 75753 | 75755 | 75844 | 75845 | 75848 | 75849 | 75850 | 75851 | 75852 | 75853 | 75854 | 75871 | 77691 | 77692 | 77693 | 77694 | 77695 | 77696 | 77697 | 78439 | 78440 | 78441 | 78442 | 78443 | 78444 | 78445 | 78446 | 78463 | 78464 | 78465 | 78466 | 78467 | 78468 | 78469 | 78470 | 79183 | 80468 | 81992 | 81993 | 82032 | 82033 | 82034 | 82035 | 82036 | 82037 | 82038 | 82039 | 82062 | 82170 | 82171 | 82432 | 82433 | 82434 | 82435 | 82436 | 82437 | 82438 | 82439 | 82440 | 82441 | 82442 | 83882 | 83887 | 84736 | 84737 | 84738 | 84739 | 84740 | 84741 | 84742 | 84743 | 84744 | 84745 | 84746 | 84747 | 84748 | 84749 | 85037 | 85038 | 85039 | 85040 | 85041 | 85042 | 85043 | 85044 | 85045 | 85046 | 85047 | 85048 | 85049 | 85050