Bugzilla – Attachment 7845 Details for
Bug 7453
Borrower without expiry date breaks opac login
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
[SIGNED-OFF] 7453 Followup for borrower without expiry date
SIGNED-OFF-7453-Followup-for-borrower-without-expi.patch (text/plain), 1.38 KB, created by
Katrin Fischer
on 2012-02-24 06:31:35 UTC
(
hide
)
Description:
[SIGNED-OFF] 7453 Followup for borrower without expiry date
Filename:
MIME Type:
Creator:
Katrin Fischer
Created:
2012-02-24 06:31:35 UTC
Size:
1.38 KB
patch
obsolete
>From 05b964ae20dd5edcc08b33bc02bcdcf78020dd69 Mon Sep 17 00:00:00 2001 >From: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> >Date: Thu, 23 Feb 2012 09:46:32 +0100 >Subject: [PATCH] [SIGNED-OFF] 7453 Followup for borrower without expiry date > >While it should be impossible now to have a patron without expiry date, I still had one. It does not hurt to add a simple check on expiry date defined before calling delta days on null values and breaking the opac login. >Trivial change. > >Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> >Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> >Tested by deleting the expirydate from my own patron record. >Missing expiry date now no longer breaks the summary page >in the patron account on OPAC. >--- > opac/opac-user.pl | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > >diff --git a/opac/opac-user.pl b/opac/opac-user.pl >index ff1fecf..a88bffb 100755 >--- a/opac/opac-user.pl >+++ b/opac/opac-user.pl >@@ -124,7 +124,7 @@ my @bordat; > $bordat[0] = $borr; > > # Warningdate is the date that the warning starts appearing >-if ( C4::Context->preference('NotifyBorrowerDeparture') && >+if ( $borr->{dateexpiry} && C4::Context->preference('NotifyBorrowerDeparture') && > Date_to_Days(Add_Delta_Days($warning_year,$warning_month,$warning_day,- C4::Context->preference('NotifyBorrowerDeparture'))) < > Date_to_Days( $today_year, $today_month, $today_day ) ) > { >-- >1.7.5.4
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 7453
:
7252
|
7358
|
7817
| 7845