Attachment 78454 Details for Bug 20592 – Bug 20592: Checks for itemnumber sooner

[patch] Bug 20592: Checks for itemnumber sooner

Bug-20592-Checks-for-itemnumber-sooner.patch (text/plain), 1.22 KB, created by Mark Tompsett on 2018-09-06 00:53:24 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Mark Tompsett

Created: 2018-09-06 00:53:24 UTC

Size: 1.22 KB

patch

obsolete

>From 7495491a0ff7d9e77287212f7eae723a3bf64b19 Mon Sep 17 00:00:00 2001
>From: Mark Tompsett <mtompset@hotmail.com>
>Date: Tue, 17 Apr 2018 23:59:58 +0000
>Subject: [PATCH] Bug 20592: Checks for itemnumber sooner
>
>Two lines of code and move them earlier.
>Add a check to make sure there are changes.
>---
> C4/Items.pm | 5 +++--
> 1 file changed, 3 insertions(+), 2 deletions(-)
>
>diff --git a/C4/Items.pm b/C4/Items.pm
>index 3f683750d9..6fc599343e 100644
>--- a/C4/Items.pm
>+++ b/C4/Items.pm
>@@ -553,6 +553,9 @@ sub ModItem {
>     my $log_action = $additional_params->{log_action} // 1;
>     my $unlinked_item_subfields = $additional_params->{unlinked_item_subfields};
> 
>+    return unless %$item;
>+    $item->{'itemnumber'} = $itemnumber or return;
>+
>     # if $biblionumber is undefined, get it from the current item
>     unless (defined $biblionumber) {
>         $biblionumber = _get_single_item_column('biblionumber', $itemnumber);
>@@ -562,8 +565,6 @@ sub ModItem {
>         $item->{'more_subfields_xml'} = _get_unlinked_subfields_xml($unlinked_item_subfields);
>     };
> 
>-    $item->{'itemnumber'} = $itemnumber or return;
>-
>     my @fields = qw( itemlost withdrawn damaged );
> 
>     # Only call GetItem if we need to set an "on" date field
>-- 
>2.11.0

Actions: View | Diff | Splinter Review

Attachments on bug 20592: 74286 | 74399 | 74400 | 74824 | 74825 | 74826 | 78453 | 78454 | 80728 | 80731 | 80732