Attachment 78460 Details for Bug 20968 – Bug 20968: Rename method get_intranet_catalog_toolbar_button to intranet_catalog_biblio_enhancements_toolbar_button

[patch] Bug 20968: Rename method get_intranet_catalog_toolbar_button to intranet_catalog_biblio_enhancements_toolbar_button

Bug-20968-Rename-method-getintranetcatalogtoolbarb.patch (text/plain), 3.18 KB, created by Andrew Isherwood on 2018-09-06 09:56:10 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Andrew Isherwood

Created: 2018-09-06 09:56:10 UTC

Size: 3.18 KB

patch

obsolete

>From 8cc3df1ad75ffdab4481f8f1bfaa8c42175e205a Mon Sep 17 00:00:00 2001
>From: Kyle M Hall <kyle@bywatetsolutions.com>
>Date: Wed, 27 Jun 2018 13:21:53 -0400
>Subject: [PATCH] Bug 20968: Rename method get_intranet_catalog_toolbar_button
> to intranet_catalog_biblio_enhancements_toolbar_button
>
>---
> catalogue/detail.pl                                      | 2 +-
> koha-tmpl/intranet-tmpl/prog/en/includes/cat-toolbar.inc | 2 +-
> t/db_dependent/Plugins.t                                 | 2 +-
> t/lib/Koha/Plugin/Test.pm                                | 4 ++--
> 4 files changed, 5 insertions(+), 5 deletions(-)
>
>diff --git a/catalogue/detail.pl b/catalogue/detail.pl
>index 73c37c6199..dd5d1830e6 100755
>--- a/catalogue/detail.pl
>+++ b/catalogue/detail.pl
>@@ -67,7 +67,7 @@ if ( C4::Context->preference('UseKohaPlugins') &&
> 	 C4::Context->config('enable_plugins') ) {
> 	# Only pass plugins that can offer a toolbar button
> 	my @plugins = Koha::Plugins->new()->GetPlugins({
>-		method => 'get_intranet_catalog_toolbar_button'
>+		method => 'intranet_catalog_biblio_enhancements_toolbar_button'
> 	});
> 	$template->param(
> 		plugins => \@plugins
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/includes/cat-toolbar.inc b/koha-tmpl/intranet-tmpl/prog/en/includes/cat-toolbar.inc
>index e1552dd1fc..f2ec6bc59d 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/includes/cat-toolbar.inc
>+++ b/koha-tmpl/intranet-tmpl/prog/en/includes/cat-toolbar.inc
>@@ -140,7 +140,7 @@ CAN_user_serials_create_subscription ) %]
> [% END %]
> 
> [% FOREACH p IN plugins %]
>-	[% p.get_intranet_catalog_toolbar_button %]
>+	[% p.intranet_catalog_biblio_enhancements_toolbar_button %]
> [% END %]
> 
> </div>
>diff --git a/t/db_dependent/Plugins.t b/t/db_dependent/Plugins.t
>index 49ce63b852..0a3d298bc5 100755
>--- a/t/db_dependent/Plugins.t
>+++ b/t/db_dependent/Plugins.t
>@@ -43,7 +43,7 @@ ok( $plugin->can('report'), 'Test plugin can report' );
> ok( $plugin->can('tool'), 'Test plugin can tool' );
> ok( $plugin->can('to_marc'), 'Test plugin can to_marc' );
> ok( $plugin->can('intranet_catalog_biblio_enhancements'), 'Test plugin can intranet_catalog_biblio_enhancements');
>-ok( $plugin->can('get_intranet_catalog_toolbar_button'), 'Test plugin can get_intranet_catalog_toolbar_button' );
>+ok( $plugin->can('intranet_catalog_biblio_enhancements_toolbar_button'), 'Test plugin can intranet_catalog_biblio_enhancements_toolbar_button' );
> ok( $plugin->can('opac_online_payment'), 'Test plugin can opac_online_payment' );
> ok( $plugin->can('opac_online_payment_begin'), 'Test plugin can opac_online_payment_begin' );
> ok( $plugin->can('opac_online_payment_end'), 'Test plugin can opac_online_payment_end' );
>diff --git a/t/lib/Koha/Plugin/Test.pm b/t/lib/Koha/Plugin/Test.pm
>index 55eb4ed0d0..59b2809bcc 100644
>--- a/t/lib/Koha/Plugin/Test.pm
>+++ b/t/lib/Koha/Plugin/Test.pm
>@@ -43,9 +43,9 @@ sub to_marc {
>     return "Koha::Plugin::Test::to_marc";
> }
> 
>-sub get_intranet_catalog_toolbar_button {
>+sub intranet_catalog_biblio_enhancements_toolbar_button {
>     my ( $self, $args ) = @_;
>-    return "Koha::Plugin::Test::get_intranet_catalog_toolbar_button";
>+    return "Koha::Plugin::Test::intranet_catalog_biblio_enhancements_toolbar_button";
> }
> 
> sub intranet_catalog_biblio_enhancements {
>-- 
>2.11.0

Actions: View | Diff | Splinter Review

Attachments on bug 20968: 76374 | 76375 | 76530 | 76531 | 76532 | 76540 | 76541 | 76555 | 76564 | 76565 | 76566 | 76567 | 76568 | 77782 | 77783 | 77784 | 77785 | 77786 | 78457 | 78458 | 78459 | 78460 | 78461 | 79804 | 79805 | 79806 | 79807 | 79808 | 80394 | 80395 | 80396 | 80397 | 80398 | 80615 | 80616 | 80617 | 80618 | 80619