Bugzilla – Attachment 78471 Details for
Bug 21320
Holds to pull should honor syspref AllowHoldsOnDamagedItems
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 21320: Holds to pull should honor syspref AllowHoldsOnDamagedItems
Bug-21320-Holds-to-pull-should-honor-syspref-Allow.patch (text/plain), 1.45 KB, created by
Dobrica Pavlinusic
on 2018-09-06 11:37:25 UTC
(
hide
)
Description:
Bug 21320: Holds to pull should honor syspref AllowHoldsOnDamagedItems
Filename:
MIME Type:
Creator:
Dobrica Pavlinusic
Created:
2018-09-06 11:37:25 UTC
Size:
1.45 KB
patch
obsolete
>From c484e275f2254ff0cbfd114638b3ff3a3c5323b9 Mon Sep 17 00:00:00 2001 >From: Dobrica Pavlinusic <dpavlin@rot13.org> >Date: Thu, 6 Sep 2018 13:21:53 +0200 >Subject: [PATCH] Bug 21320: Holds to pull should honor syspref > AllowHoldsOnDamagedItems > >Test plan: > >1. Set syspref AllowHoldsOnDamagedItems to Allow >2. Create a hold on record with item which is damaged >3. Verify that it doesn't appear in report >4. Apply patch and verify that it's now visible >--- > circ/pendingreserves.pl | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > >diff --git a/circ/pendingreserves.pl b/circ/pendingreserves.pl >index 7f03d88..7a827f6 100755 >--- a/circ/pendingreserves.pl >+++ b/circ/pendingreserves.pl >@@ -170,6 +170,8 @@ if ($enddate_iso) { > > my $item_type = C4::Context->preference('item-level_itypes') ? "items.itype" : "biblioitems.itemtype"; > >+my $allow_damaged = C4::Context->preference('AllowHoldsOnDamagedItems') || 0; >+ > my $strsth = > "SELECT min(reservedate) as l_reservedate, > reserves.reserve_id, >@@ -214,7 +216,7 @@ my $strsth = > AND issues.itemnumber IS NULL > AND reserves.priority <> 0 > AND reserves.suspend = 0 >- AND notforloan = 0 AND damaged = 0 AND itemlost = 0 AND withdrawn = 0 >+ AND notforloan = 0 AND damaged = $allow_damaged AND itemlost = 0 AND withdrawn = 0 > "; > # GROUP BY reserves.biblionumber allows only items that are not checked out, else multiples occur when > # multiple patrons have a hold on an item >-- >2.1.4
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 21320
:
78471
|
78472
|
80255