Attachment 78486 Details for Bug 7534 – Bug 7534: Disambiguate branchcode parameter, make it match between subroutines

[patch] Bug 7534: Disambiguate branchcode parameter, make it match between subroutines

Bug-7534-Disambiguate-branchcode-parameter-make-it.patch (text/plain), 1.86 KB, created by Kyle M Hall (khall) on 2018-09-06 13:47:20 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Kyle M Hall (khall)

Created: 2018-09-06 13:47:20 UTC

Size: 1.86 KB

patch

obsolete

>From 90a86473c1b1e678ab7503a1d7be3004ead99f50 Mon Sep 17 00:00:00 2001
>From: Kyle M Hall <kyle@bywatersolutiosn.com>
>Date: Wed, 15 Aug 2018 13:51:10 -0400
>Subject: [PATCH] Bug 7534: Disambiguate branchcode parameter, make it match
> between subroutines
>
>---
> C4/Reserves.pm | 10 +++++-----
> 1 file changed, 5 insertions(+), 5 deletions(-)
>
>diff --git a/C4/Reserves.pm b/C4/Reserves.pm
>index d7b9c9a1af..e8d3a10143 100644
>--- a/C4/Reserves.pm
>+++ b/C4/Reserves.pm
>@@ -273,7 +273,7 @@ See CanItemBeReserved() for possible return values.
> =cut
> 
> sub CanBookBeReserved{
>-    my ($borrowernumber, $biblionumber, $branchcode) = @_;
>+    my ($borrowernumber, $biblionumber, $pickup_branchcode) = @_;
> 
>     my @itemnumbers = Koha::Items->search({ biblionumber => $biblionumber})->get_column("itemnumber");
>     #get items linked via host records
>@@ -284,7 +284,7 @@ sub CanBookBeReserved{
> 
>     my $canReserve;
>     foreach my $itemnumber (@itemnumbers) {
>-        $canReserve = CanItemBeReserved( $borrowernumber, $itemnumber, $branchcode );
>+        $canReserve = CanItemBeReserved( $borrowernumber, $itemnumber, $pickup_branchcode );
>         return $canReserve if $canReserve->{status} eq 'OK';
>     }
>     return $canReserve;
>@@ -307,7 +307,7 @@ sub CanBookBeReserved{
> =cut
> 
> sub CanItemBeReserved {
>-    my ( $borrowernumber, $itemnumber, $branchcode_to ) = @_;
>+    my ( $borrowernumber, $itemnumber, $pickup_branchcode ) = @_;
> 
>     my $dbh = C4::Context->dbh;
>     my $ruleitemtype;    # itemtype of the matching issuing rule
>@@ -460,9 +460,9 @@ sub CanItemBeReserved {
>         }
>     }
> 
>-    if ($branchcode_to) {
>+    if ($pickup_branchcode) {
>         my $destination = Koha::Libraries->find({
>-            branchcode => $branchcode_to,
>+            branchcode => $pickup_branchcode,
>         });
>         unless ($destination) {
>             return { status => 'libraryNotFound' };
>-- 
>2.11.0

Actions: View | Diff | Splinter Review

Attachments on bug 7534: 60014 | 60015 | 60016 | 60017 | 60018 | 60022 | 60023 | 60781 | 60794 | 60795 | 60796 | 60797 | 60798 | 60799 | 60878 | 60879 | 60880 | 60881 | 60882 | 60883 | 61044 | 61045 | 61046 | 61047 | 61273 | 61274 | 61275 | 61276 | 61277 | 61278 | 61279 | 61280 | 77847 | 77848 | 77849 | 77850 | 77851 | 77852 | 77853 | 77854 | 77855 | 77856 | 78160 | 78161 | 78162 | 78163 | 78164 | 78165 | 78166 | 78167 | 78168 | 78169 | 78170 | 78171 | 78477 | 78478 | 78479 | 78480 | 78481 | 78482 | 78483 | 78484 | 78485 | 78486 | 78487 | 78488 | 78489 | 78495 | 78540 | 78548 | 84852