Attachment 78489 Details for Bug 7534 – Bug 7534 [QA Followup]: Don't do pickup branch checking for determining holdability in the OPAC

[patch] Bug 7534 [QA Followup]: Don't do pickup branch checking for determining holdability in the OPAC

Bug-7534-QA-Followup-Dont-do-pickup-branch-checkin.patch (text/plain), 2.17 KB, created by Kyle M Hall (khall) on 2018-09-06 13:50:57 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Kyle M Hall (khall)

Created: 2018-09-06 13:50:57 UTC

Size: 2.17 KB

patch

obsolete

>From bab6c67387acefbcb8ab0e019ebc1a2d28109f7c Mon Sep 17 00:00:00 2001
>From: Kyle M Hall <kyle@bywatersolutiosn.com>
>Date: Thu, 6 Sep 2018 09:50:04 -0400
>Subject: [PATCH] Bug 7534 [QA Followup]: Don't do pickup branch checking for
> determining holdability in the OPAC
>
>---
> opac/opac-reserve.pl | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
>diff --git a/opac/opac-reserve.pl b/opac/opac-reserve.pl
>index 89af3b0e52..684e57d1c3 100755
>--- a/opac/opac-reserve.pl
>+++ b/opac/opac-reserve.pl
>@@ -269,10 +269,10 @@ if ( $query->param('place_reserve') ) {
> 
>         my $rank = $biblioData->{rank};
>         if ( $itemNum ne '' ) {
>-            $canreserve = 1 if CanItemBeReserved( $borrowernumber, $itemNum, $branch )->{status} eq 'OK';
>+            $canreserve = 1 if CanItemBeReserved( $borrowernumber, $itemNum )->{status} eq 'OK';
>         }
>         else {
>-            $canreserve = 1 if CanBookBeReserved( $borrowernumber, $biblioNum, $branch )->{status} eq 'OK';
>+            $canreserve = 1 if CanBookBeReserved( $borrowernumber, $biblioNum )->{status} eq 'OK';
> 
>             # Inserts a null into the 'itemnumber' field of 'reserves' table.
>             $itemNum = undef;
>@@ -525,7 +525,7 @@ foreach my $biblioNum (@biblionumbers) {
>         my $policy_holdallowed = !$itemLoopIter->{already_reserved};
>         $policy_holdallowed &&=
>             IsAvailableForItemLevelRequest($itemInfo,$patron_unblessed) &&
>-            CanItemBeReserved($borrowernumber,$itemNum, $branch)->{status} eq 'OK';
>+            CanItemBeReserved( $borrowernumber, $itemNum )->{status} eq 'OK';
> 
>         if ($policy_holdallowed) {
>             my $opac_hold_policy = Koha::IssuingRules->get_opacitemholds_policy( { item => $item, patron => $patron } );
>@@ -585,7 +585,7 @@ foreach my $biblioNum (@biblionumbers) {
>         }
>     }
> 
>-    $biblioLoopIter{holdable} &&= CanBookBeReserved($borrowernumber,$biblioNum,$branch)->{status} eq 'OK';
>+    $biblioLoopIter{holdable} &&= CanBookBeReserved( $borrowernumber, $biblioNum )->{status} eq 'OK';
> 
>     # For multiple holds per record, if a patron has previously placed a hold,
>     # the patron can only place more holds of the same type. That is, if the
>-- 
>2.11.0

Actions: View | Diff | Splinter Review

Attachments on bug 7534: 60014 | 60015 | 60016 | 60017 | 60018 | 60022 | 60023 | 60781 | 60794 | 60795 | 60796 | 60797 | 60798 | 60799 | 60878 | 60879 | 60880 | 60881 | 60882 | 60883 | 61044 | 61045 | 61046 | 61047 | 61273 | 61274 | 61275 | 61276 | 61277 | 61278 | 61279 | 61280 | 77847 | 77848 | 77849 | 77850 | 77851 | 77852 | 77853 | 77854 | 77855 | 77856 | 78160 | 78161 | 78162 | 78163 | 78164 | 78165 | 78166 | 78167 | 78168 | 78169 | 78170 | 78171 | 78477 | 78478 | 78479 | 78480 | 78481 | 78482 | 78483 | 78484 | 78485 | 78486 | 78487 | 78488 | 78489 | 78495 | 78540 | 78548 | 84852