Bugzilla – Attachment 78499 Details for
Bug 17530
Don't show 'article request' link when no article requests are permitted
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 17530: (QA follow-up) Fix caching error
Bug-17530-QA-follow-up-Fix-caching-error.patch (text/plain), 1.21 KB, created by
Marcel de Rooy
on 2018-09-07 06:21:08 UTC
(
hide
)
Description:
Bug 17530: (QA follow-up) Fix caching error
Filename:
MIME Type:
Creator:
Marcel de Rooy
Created:
2018-09-07 06:21:08 UTC
Size:
1.21 KB
patch
obsolete
>From 5e4e3f2e0e461603904db2301358d41dc4798e71 Mon Sep 17 00:00:00 2001 >From: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> >Date: Fri, 7 Sep 2018 07:50:13 +0200 >Subject: [PATCH] Bug 17530: (QA follow-up) Fix caching error >Content-Type: text/plain; charset=utf-8 > >The fourth patch made this change: >- $last_article_requestable_guesses->{$key} = $res; >+ $cache->set_in_cache(GUESSED_ITEMTYPES_KEY, $res); > >This removed the category level in the cached hash. Adding it back here. > >Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> >Tested by verifying cached values, running opac-search with anonymous >session as well as user context. >--- > Koha/IssuingRules.pm | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > >diff --git a/Koha/IssuingRules.pm b/Koha/IssuingRules.pm >index 9ec3ee5..608b4ed 100644 >--- a/Koha/IssuingRules.pm >+++ b/Koha/IssuingRules.pm >@@ -182,7 +182,8 @@ sub guess_article_requestable_itemtypes { > foreach my $rule ( $rules->as_list ) { > $res->{ $rule->itemtype } = 1; > } >- $cache->set_in_cache(GUESSED_ITEMTYPES_KEY, $res); >+ $last_article_requestable_guesses->{$key} = $res; >+ $cache->set_in_cache(GUESSED_ITEMTYPES_KEY, $last_article_requestable_guesses); > return $res; > } > >-- >2.1.4
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 17530
:
72857
|
72858
|
72859
|
72860
|
72909
|
72910
|
72911
|
72912
|
72913
|
72914
|
72915
|
72930
|
72931
|
75697
|
75751
|
76617
|
76618
|
76619
|
76620
|
76621
|
76622
|
77258
|
77259
|
77260
|
77261
|
77262
|
77263
|
78030
|
78031
|
78032
|
78033
|
78034
|
78035
|
78362
|
78363
|
78364
|
78365
|
78366
|
78367
|
78368
| 78499