Bugzilla – Attachment 78558 Details for
Bug 15219
Server-side processing and pagination on checkouts tables
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 15219: Do not call escapeHtml on null values
Bug-15219-Do-not-call-escapeHtml-on-null-values.patch (text/plain), 2.49 KB, created by
Julian Maurice
on 2018-09-11 15:20:14 UTC
(
hide
)
Description:
Bug 15219: Do not call escapeHtml on null values
Filename:
MIME Type:
Creator:
Julian Maurice
Created:
2018-09-11 15:20:14 UTC
Size:
2.49 KB
patch
obsolete
>From 23fb26e98bc52029a5c7287de1ffb695df99faac Mon Sep 17 00:00:00 2001 >From: Julian Maurice <julian.maurice@biblibre.com> >Date: Tue, 11 Sep 2018 16:53:42 +0200 >Subject: [PATCH] Bug 15219: Do not call escapeHtml on null values > >--- > koha-tmpl/intranet-tmpl/prog/js/checkouts.js | 18 +++++++++--------- > 1 file changed, 9 insertions(+), 9 deletions(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/js/checkouts.js b/koha-tmpl/intranet-tmpl/prog/js/checkouts.js >index 8a68cede21..9c6ef36d5a 100644 >--- a/koha-tmpl/intranet-tmpl/prog/js/checkouts.js >+++ b/koha-tmpl/intranet-tmpl/prog/js/checkouts.js >@@ -112,25 +112,25 @@ var renderers = { > return title; > }, > itemtype: function (data, type, row) { >- return row.itemtype_description.escapeHtml(); >+ return row.itemtype_description ? row.itemtype_description.escapeHtml() : ''; > }, > collection: function (data, type, row) { >- return row.collection.escapeHtml(); >+ return row.collection ? row.collection.escapeHtml() : ''; > }, > location: function (data, type, row) { >- return row.location.escapeHtml(); >+ return row.location ? row.location.escapeHtml() : ''; > }, > homebranch: function (data, type, row) { >- return row.homebranch.escapeHtml(); >+ return row.homebranch ? row.homebranch.escapeHtml() : ''; > }, > issuedate: function (data, type, row) { > return row.issuedate_formatted; > }, > branch: function (data, type, row) { >- return row.branchname.escapeHtml(); >+ return row.branchname ? row.branchname.escapeHtml() : ''; > }, > itemcallnumber: function (data, type, row) { >- return row.itemcallnumber.escapeHtml(); >+ return row.itemcallnumber ? row.itemcallnumber.escapeHtml() : ''; > }, > charge: function (data, type, row) { > if (!row.charge) row.charge = 0; >@@ -270,10 +270,10 @@ var renderers = { > }, > patron: function (data, type, row) { > return "<a href='/cgi-bin/koha/members/moremember.pl?borrowernumber=" + row.borrowernumber + "'>" >- + row.borrower.firstname.escapeHtml() >+ + (row.borrower.firstname ? row.borrower.firstname.escapeHtml() : '') > + " " >- + row.borrower.surname.escapeHtml() >- + " (" + row.borrower.cardnumber.escapeHtml() + ")</a>" >+ + (row.borrower.surname ? row.borrower.surname.escapeHtml() : '') >+ + " (" + (row.borrower.cardnumber ? row.borrower.cardnumber.escapeHtml() : '') + ")</a>" > } > }; > >-- >2.17.1
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 15219
:
45018
|
45036
|
45054
|
48107
|
50075
|
60071
|
60642
|
61158
|
61159
|
61545
|
61546
|
72905
|
72906
|
74224
|
74225
|
75911
|
75912
|
75913
|
78555
|
78556
|
78557
|
78558
|
78559
|
79195
|
79196
|
79197
|
79198
|
79199
|
92776
|
92777
|
92778
|
92779
|
92780
|
92781
|
93921