Bugzilla – Attachment 78625 Details for
Bug 13392
New statistics wizard for suggestions
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 13392 - Fix QA failures:
Bug-13392---Fix-QA-failures.patch (text/plain), 2.98 KB, created by
Julian Maurice
on 2018-09-13 14:59:01 UTC
(
hide
)
Description:
Bug 13392 - Fix QA failures:
Filename:
MIME Type:
Creator:
Julian Maurice
Created:
2018-09-13 14:59:01 UTC
Size:
2.98 KB
patch
obsolete
>From 06f8d07ddeafc153ad43a7a5d8e5910955d5e35a Mon Sep 17 00:00:00 2001 >From: Alex Arnaud <alex.arnaud@biblibre.com> >Date: Thu, 18 Jun 2015 16:26:44 +0200 >Subject: [PATCH] Bug 13392 - Fix QA failures: > > - Fix a perl warning in suggestions_stats.tt, > - Replace term "Acquisitions" with "Suggestions", > - Add POD for GetBudgetDescendantsIds. > >Signed-off-by: Josef Moravec <josef.moravec@gmail.com> >--- > C4/Budgets.pm | 8 ++++++++ > .../prog/en/modules/reports/suggestions_stats.tt | 4 ++-- > .../prog/en/modules/reports/suggestions_stats_results.tt | 4 ++-- > 3 files changed, 12 insertions(+), 4 deletions(-) > >diff --git a/C4/Budgets.pm b/C4/Budgets.pm >index 7d77d04dce..d812458147 100644 >--- a/C4/Budgets.pm >+++ b/C4/Budgets.pm >@@ -193,6 +193,14 @@ sub GetBudgetChildren { > |, { Slice => {} }, $budget_id ); > } > >+=head2 GetBudgetDescendantsIds >+ >+ my @descendants_ids = GetBudgetDescendantsIds($parent_id); >+ >+Get ids of all descendants of a given budget id. >+ >+=cut >+ > sub GetBudgetDescendantsIds { > my ($budget_id) = @_; > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/reports/suggestions_stats.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/reports/suggestions_stats.tt >index ee538467bb..bbd832221a 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/reports/suggestions_stats.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/reports/suggestions_stats.tt >@@ -40,7 +40,7 @@ > > [% BLOCK select_tr %] > [% select_filter = BLOCK %] >- [% IF display_values.$name.keys.size > 0 %] >+ [% IF display_values.$name.keys.size %] > <select name="filter_[% name %]"> > <option value=""></option> > [% FOREACH value IN display_values.$name.keys.sort %] >@@ -117,7 +117,7 @@ > > <form method="post" action="/cgi-bin/koha/reports/suggestions_stats.pl"> > <fieldset class="rows"> >- <legend>Acquisitions statistics</legend> >+ <legend>Suggestions statistics</legend> > <table> > <thead> > <tr> >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/reports/suggestions_stats_results.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/reports/suggestions_stats_results.tt >index 2e00d47c14..fdb53807dc 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/reports/suggestions_stats_results.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/reports/suggestions_stats_results.tt >@@ -2,7 +2,7 @@ > [% PROCESS 'reports/display_values_status.inc' %] > > [% INCLUDE 'doc-head-open.inc' %] >- <title>Koha › Reports › Acquisitions statistics results</title> >+ <title>Koha › Reports › Suggestions statistics results</title> > [% INCLUDE 'doc-head-close.inc' %] > [% INCLUDE 'calendar.inc' %] > </head> >@@ -25,7 +25,7 @@ > <div id="yui-main"> > <div class="yui-b"> > >- <h1>Acquisitions statistics </h1> >+ <h1>Suggestions statistics </h1> > [% IF filters.keys.size %] > <p><b>Filtered on:</b></p> > <ul> >-- >2.17.1
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 13392
:
34124
|
34125
|
34135
|
34136
|
34328
|
34329
|
35835
|
35836
|
35837
|
36188
|
36189
|
36190
|
36343
|
36344
|
36345
|
40305
|
40306
|
40307
|
40308
|
48291
|
48292
|
48293
|
48294
|
49088
|
51995
|
51996
|
51997
|
51998
|
51999
|
56110
|
56889
|
60956
|
60957
|
60958
|
60959
|
60960
|
60961
|
60962
|
64459
|
64460
|
64461
|
64462
|
64463
|
64464
|
64465
|
78622
|
78623
|
78624
| 78625 |
78626
|
78627
|
78628
|
78629