Bugzilla – Attachment 78644 Details for
Bug 21248
Fix COinS carp in MARC details page on unknown record
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 21248: Fix COinS carp in MARC details page on unknown record
Bug-21248-Fix-COinS-carp-in-MARC-details-page-on-u.patch (text/plain), 1.81 KB, created by
Marcel de Rooy
on 2018-09-14 09:44:49 UTC
(
hide
)
Description:
Bug 21248: Fix COinS carp in MARC details page on unknown record
Filename:
MIME Type:
Creator:
Marcel de Rooy
Created:
2018-09-14 09:44:49 UTC
Size:
1.81 KB
patch
obsolete
>From 7db3d735cc2dbcd675563eead6a3880aa99a08be Mon Sep 17 00:00:00 2001 >From: Pasi Kallinen <pasi.kallinen@joensuu.fi> >Date: Mon, 20 Aug 2018 07:30:45 +0300 >Subject: [PATCH] Bug 21248: Fix COinS carp in MARC details page on unknown > record >Content-Type: text/plain; charset=utf-8 > >Looking up a nonexistent record in the MARC details -page causes >the COinS to carp. The fix is trivial, just move the COinS call >couple lines, after the record existence check. > >TEST PLAN >--------- >1) reset_all for kohadevbox >2) log in to staff client - admin/admin >3) search catalogue for green >4) tweak the top URL to have a bad biblionumber (eg. 9999) >5) cat /var/log/koha/kohadev/plack-err.log > -- floody! with errors. >6) echo | sudo tee /var/log/koha/kohadev/plack-err.log >7) restart_all >8) repeat steps 2 through 5. > -- just nice starting messages, not floody. >9) run koha qa test tools > >Signed-off-by: Mark Tompsett <mtompset@hotmail.com> > >Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> >--- > catalogue/MARCdetail.pl | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > >diff --git a/catalogue/MARCdetail.pl b/catalogue/MARCdetail.pl >index 8940471..b4adcfd 100755 >--- a/catalogue/MARCdetail.pl >+++ b/catalogue/MARCdetail.pl >@@ -90,7 +90,6 @@ my ( $template, $loggedinuser, $cookie ) = get_template_and_user( > my $record = GetMarcBiblio({ > biblionumber => $biblionumber, > embed_items => 1 }); >-$template->param( ocoins => GetCOinSBiblio($record) ); > > if ( not defined $record ) { > # biblionumber invalid -> report and exit >@@ -101,6 +100,8 @@ if ( not defined $record ) { > exit; > } > >+$template->param( ocoins => GetCOinSBiblio($record) ); >+ > my $biblio_object = Koha::Biblios->find( $biblionumber ); # FIXME Should replace $biblio > my $tagslib = &GetMarcStructure(1,$frameworkcode); > my $biblio = GetBiblioData($biblionumber); >-- >2.1.4
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 21248
:
78011
|
78451
| 78644