Attachment 78685 Details for Bug 12365 – Bug 12365: Notes for rules

[patch] Bug 12365: Notes for rules

Bug-12365-Notes-for-rules.patch (text/plain), 7.06 KB, created by Chris Cormack on 2018-09-14 18:12:02 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Chris Cormack

Created: 2018-09-14 18:12:02 UTC

Size: 7.06 KB

patch

obsolete

>From 15ec0043aff6b76e7c57bd7a0e61ed65ff85735d Mon Sep 17 00:00:00 2001
>From: Aleisha Amohia <aleishaamohia@hotmail.com>
>Date: Mon, 19 Jun 2017 19:47:52 +0000
>Subject: [PATCH] Bug 12365: Notes for rules
>
>This patch adds a note column to the circ and fine rules to act as a
>description line for the rule.
>
>To test:
>1) Apply patch, update database (may have to also update schema)
>2) Go to Admin -> Circ and fine rules
>3) Scroll to the right, notice new Note column
>4) Confirm it works to create a brand new rule with a Note
>5) Confirm it works to modify an existing rule with a Note
>
>Sponsored-by: Catalyst IT
>
>Lee Jamison <ldjamison@marywood.edu> rescued this patch.
>It is a clean re-build of attachments 61865 and 63902
>to fix the merge conflict introduced during application of both
>attachments.
>
>Signed-off-by: Mark Tompsett <mtompset@hotmail.com>
>
>Signed-off-by: macon  lauren KohaCon17 <caballeromaricon@gmail.com>
>
>Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
>
>Signed-off-by: Owen Leonard <oleonard@myacpl.org>
>---
> Koha/Schema/Result/Issuingrule.pm                                | 8 ++++++++
> admin/smart-rules.pl                                             | 2 ++
> .../bug_12365_-_add_note_column_to_issuingrules.perl             | 9 +++++++++
> installer/data/mysql/kohastructure.sql                           | 1 +
> koha-tmpl/intranet-tmpl/prog/en/modules/admin/smart-rules.tt     | 6 +++++-
> 5 files changed, 25 insertions(+), 1 deletion(-)
> create mode 100644 installer/data/mysql/atomicupdate/bug_12365_-_add_note_column_to_issuingrules.perl
>
>diff --git a/Koha/Schema/Result/Issuingrule.pm b/Koha/Schema/Result/Issuingrule.pm
>index 5958055104..602f406d7d 100644
>--- a/Koha/Schema/Result/Issuingrule.pm
>+++ b/Koha/Schema/Result/Issuingrule.pm
>@@ -221,6 +221,12 @@ __PACKAGE__->table("issuingrules");
>   extra: {list => ["no","yes","bib_only","item_only"]}
>   is_nullable: 0
> 
>+=head2 note
>+
>+  data_type: 'varchar'
>+  is_nullable: 1
>+  size: 100
>+
> =cut
> 
> __PACKAGE__->add_columns(
>@@ -302,6 +308,8 @@ __PACKAGE__->add_columns(
>     extra => { list => ["no", "yes", "bib_only", "item_only"] },
>     is_nullable => 0,
>   },
>+  "note",
>+  { data_type => "varchar", is_nullable => 1, size => 100 },
> );
> 
> =head1 PRIMARY KEY
>diff --git a/admin/smart-rules.pl b/admin/smart-rules.pl
>index d87d8e5451..25fa3e1c86 100755
>--- a/admin/smart-rules.pl
>+++ b/admin/smart-rules.pl
>@@ -164,6 +164,7 @@ elsif ($op eq 'add') {
>     my $article_requests = $input->param('article_requests') || 'no';
>     my $overduefinescap = $input->param('overduefinescap') || undef;
>     my $cap_fine_to_replacement_price = $input->param('cap_fine_to_replacement_price') eq 'on';
>+    my $note = $input->param('note');
>     $debug and warn "Adding $br, $bor, $itemtype, $fine, $maxissueqty, $maxonsiteissueqty, $cap_fine_to_replacement_price";
> 
>     my $params = {
>@@ -197,6 +198,7 @@ elsif ($op eq 'add') {
>         overduefinescap               => $overduefinescap,
>         cap_fine_to_replacement_price => $cap_fine_to_replacement_price,
>         article_requests              => $article_requests,
>+        note                          => $note,
>     };
> 
>     my $issuingrule = Koha::IssuingRules->find({categorycode => $bor, itemtype => $itemtype, branchcode => $br});
>diff --git a/installer/data/mysql/atomicupdate/bug_12365_-_add_note_column_to_issuingrules.perl b/installer/data/mysql/atomicupdate/bug_12365_-_add_note_column_to_issuingrules.perl
>new file mode 100644
>index 0000000000..6b4d671c0b
>--- /dev/null
>+++ b/installer/data/mysql/atomicupdate/bug_12365_-_add_note_column_to_issuingrules.perl
>@@ -0,0 +1,9 @@
>+$DBversion = 'XXX';
>+if( CheckVersion( $DBversion ) ) {
>+    unless( column_exists( 'issuingrules', 'note' ) ) {
>+        $dbh->do(q|ALTER TABLE issuingrules ADD note varchar(100) default NULL AFTER article_requests|);
>+    }
>+
>+    SetVersion( $DBversion );
>+    print "Upgrade to $DBversion done (Bug 12365: Add column issuingrules.note)\n";
>+}
>diff --git a/installer/data/mysql/kohastructure.sql b/installer/data/mysql/kohastructure.sql
>index 3048ade972..750797e34b 100644
>--- a/installer/data/mysql/kohastructure.sql
>+++ b/installer/data/mysql/kohastructure.sql
>@@ -866,6 +866,7 @@ CREATE TABLE `issuingrules` ( -- circulation and fine rules
>   onshelfholds tinyint(1) NOT NULL default 0, -- allow holds for items that are on shelf
>   opacitemholds char(1) NOT NULL default 'N', -- allow opac users to place specific items on hold
>   article_requests enum('no','yes','bib_only','item_only') NOT NULL DEFAULT 'no', -- allow article requests to be placed,
>+  `note` varchar(100) default NULL, -- description of rule, reason for setting rule
>   PRIMARY KEY  (`branchcode`,`categorycode`,`itemtype`),
>   KEY `categorycode` (`categorycode`),
>   KEY `itemtype` (`itemtype`)
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/smart-rules.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/smart-rules.tt
>index 5bc7e003cf..ae501b682d 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/smart-rules.tt
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/smart-rules.tt
>@@ -93,6 +93,7 @@
>                 <th>Item level holds</th>
>                 <th>Article requests</th>
>                 <th>Rental discount (%)</th>
>+                <th>Note</th>
>                 <th>Actions</th>
>             </tr>
>             </thead>
>@@ -212,7 +213,8 @@
>                                                                 <span>Item only</span>
>                                                             [% END %]
>                                                         </td>
>-							<td>[% rule.rentaldiscount | html %]</td>
>+                                                        <td>[% rule.rentaldiscount | html %]</td>
>+                                                        <td>[% rule.note | html %]</td>
>                                                         <td class="actions">
>                                                           <a href="#" class="editrule btn btn-default btn-xs"><i class="fa fa-pencil"></i> Edit</a>
>                                                           <a class="btn btn-default btn-xs delete" href="/cgi-bin/koha/admin/smart-rules.pl?op=delete&amp;itemtype=[% rule.itemtype | html %]&amp;categorycode=[% rule.categorycode | html %]&amp;branch=[% rule.current_branch | html %]"><i class="fa fa-trash"></i> Delete</a>
>@@ -313,6 +315,7 @@
>                         </select>
>                     </td>
>                     <td><input type="text" name="rentaldiscount" id="rentaldiscount" size="2" /></td>
>+                    <td><input type="text" name="note" id="note" size="15" value=""></td>
>                     <td class="actions">
>                         <input type="hidden" name="branch" value="[% current_branch | html %]"/>
>                         <button type="submit" class="btn btn-default btn-xs"><i class="fa fa-save"></i> Save</button>
>@@ -350,6 +353,7 @@
>                       <th>Item level holds</th>
>                       <th>Article requests</th>
>                       <th>Rental discount (%)</th>
>+                      <th>Note</th>
>                       <th>&nbsp;</th>
>                     </tr>
>                   </tfoot>
>-- 
>2.11.0

Actions: View | Diff | Splinter Review

Attachments on bug 12365: 61865 | 63902 | 64441 | 64443 | 64565 | 66829 | 66830 | 67802 | 76609 | 76637 | 76658 | 77147 | 77275 | 78685 | 78686 | 80790 | 80956 | 80957 | 80958 | 80997 | 80998 | 81603 | 81604 | 81605 | 81606 | 81647 | 81648 | 81649 | 81650 | 82081