Bugzilla – Attachment 78872 Details for
Bug 21353
Merge patrons option only available with manage_patron_lists
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 21353: Display checkboxes to merge patron even if cannot manage lists
Bug-21353-Display-checkboxes-to-merge-patron-even-.patch (text/plain), 3.13 KB, created by
Jonathan Druart
on 2018-09-15 18:03:58 UTC
(
hide
)
Description:
Bug 21353: Display checkboxes to merge patron even if cannot manage lists
Filename:
MIME Type:
Creator:
Jonathan Druart
Created:
2018-09-15 18:03:58 UTC
Size:
3.13 KB
patch
obsolete
>From e3cd2d01ce7294e08258733a03d340ce7a965679 Mon Sep 17 00:00:00 2001 >From: Jonathan Druart <jonathan.druart@bugs.koha-community.org> >Date: Sat, 15 Sep 2018 11:02:05 -0700 >Subject: [PATCH] Bug 21353: Display checkboxes to merge patron even if cannot > manage lists > >When permission 'manage_patron_lists' is off, there is no checkbox on >/cgi-bin/koha/members/member.pl to merge patrons. > >Test plan: >Remove permission manage_patron_lists >Add permission edit_borrowers >Search for patrons >=> Without this patch you will not be able to select patrons to merge >(checkboxes are not displayed) >--- > koha-tmpl/intranet-tmpl/prog/en/modules/members/member.tt | 6 +++--- > .../intranet-tmpl/prog/en/modules/members/tables/members_results.tt | 2 +- > 2 files changed, 4 insertions(+), 4 deletions(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/members/member.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/members/member.tt >index 5f6b364727..98d5d65307 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/members/member.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/members/member.tt >@@ -92,7 +92,7 @@ > <table id="memberresultst"> > <thead> > <tr> >- [% IF CAN_user_tools_manage_patron_lists %] >+ [% IF CAN_user_borrowers_edit_borrowers || CAN_user_tools_manage_patron_lists %] > <th> </th> > [% END %] > <th>Card</th> >@@ -403,7 +403,7 @@ > > // Apply DataTables on the results table > var columns_settings = [% ColumnsSettings.GetColumns( 'members', 'member', 'memberresultst', 'json' ) | $raw %]; >- [% UNLESS CAN_user_tools_manage_patron_lists %] >+ [% UNLESS CAN_user_borrowers_edit_borrowers OR CAN_user_tools_manage_patron_lists %] > [%# Remove the first column if we do not display the checkbox %] > columns_settings.splice(0, 1); > [% END %] >@@ -465,7 +465,7 @@ > }); > }, > 'aoColumns':[ >- [% IF CAN_user_tools_manage_patron_lists %] >+ [% IF CAN_user_borrowers_edit_borrowers || CAN_user_tools_manage_patron_lists %] > { 'mDataProp': 'dt_borrowernumber', 'bSortable': false }, > [% END %] > { 'mDataProp': 'dt_cardnumber' }, >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/members/tables/members_results.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/members/tables/members_results.tt >index 6799c31032..066ada1708 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/members/tables/members_results.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/members/tables/members_results.tt >@@ -10,7 +10,7 @@ > "aaData": [ > [% FOREACH data IN aaData %] > { >- [% IF CAN_user_tools_manage_patron_lists %] >+ [% IF CAN_user_borrowers_edit_borrowers || CAN_user_tools_manage_patron_lists %] > "dt_borrowernumber": > "<input type='checkbox' class='selection' name='borrowernumber' value='[% data.borrowernumber | html %]' />", > [% END %] >-- >2.11.0
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 21353
:
78872
|
78957
|
78971
|
78972
|
79335
|
79336