Attachment 79047 Details for Bug 19945 – Bug 19945: (follow-up) optimization and test correction

[patch] Bug 19945: (follow-up) optimization and test correction

Bug-19945-follow-up-optimization-and-test-correcti.patch (text/plain), 1.89 KB, created by Alex Arnaud on 2018-09-18 13:07:24 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Alex Arnaud

Created: 2018-09-18 13:07:24 UTC

Size: 1.89 KB

patch

obsolete

>From 10bceb86bb5f8f3556802a3033172fa94a6b335d Mon Sep 17 00:00:00 2001
>From: Mark Tompsett <mtompset@hotmail.com>
>Date: Tue, 27 Mar 2018 19:31:36 +0000
>Subject: [PATCH] Bug 19945: (follow-up) optimization and test correction
>
>The double call to CanItemBeReserved was pointless in
>the C4/Reserves.pm HoldItem, as CanBookBeReserved calls
>CanItemBeReserved and even returns that code.
>
>Additionally, the tests failed, because there were 5
>tests not 4.
>
>TEST PLAN
>----------
>prove t/db_dependent/ILSDI_Services.t
>run koha qa test tools
>
>Signed-off-by: Mark Tompsett <mtompset@hotmail.com>
>
>Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
>---
> C4/ILSDI/Services.pm            | 3 +--
> t/db_dependent/ILSDI_Services.t | 2 +-
> 2 files changed, 2 insertions(+), 3 deletions(-)
>
>diff --git a/C4/ILSDI/Services.pm b/C4/ILSDI/Services.pm
>index b890bb0..034f55a 100644
>--- a/C4/ILSDI/Services.pm
>+++ b/C4/ILSDI/Services.pm
>@@ -744,9 +744,8 @@ sub HoldItem {
>     return { code => 'RecordNotFound' } if $$item{biblionumber} ne $biblio->biblionumber;
> 
>     # Check for item disponibility
>-    my $canitembereserved = C4::Reserves::CanItemBeReserved( $borrowernumber, $itemnumber )->{status};
>+    # CanItemBeReserved codes are passed back too.
>     my $canbookbereserved = C4::Reserves::CanBookBeReserved( $borrowernumber, $biblionumber )->{status};
>-    return { code => $canitembereserved } unless $canitembereserved eq 'OK';
>     return { code => $canbookbereserved } unless $canbookbereserved eq 'OK';
> 
>     # Pickup branch management
>diff --git a/t/db_dependent/ILSDI_Services.t b/t/db_dependent/ILSDI_Services.t
>index 54d700d..06d25f6 100644
>--- a/t/db_dependent/ILSDI_Services.t
>+++ b/t/db_dependent/ILSDI_Services.t
>@@ -19,7 +19,7 @@ use Modern::Perl;
> 
> use CGI qw ( -utf8 );
> 
>-use Test::More tests => 4;
>+use Test::More tests => 5;
> use Test::MockModule;
> use t::lib::Mocks;
> use t::lib::TestBuilder;
>-- 
>2.7.4

Actions: View | Diff | Splinter Review

Attachments on bug 19945: 70409 | 73351 | 73352 | 75688 | 75689 | 79046 | 79047 | 79048 | 79049 | 81371 | 81372 | 81373 | 81374 | 83745 | 83746 | 83747 | 83748