Attachment 79054 Details for Bug 13406 – Bug 13406: (follow-up) Add styling classes to authority MARC detail display

[patch] Bug 13406: (follow-up) Add styling classes to authority MARC detail display

Bug-13406-follow-up-Add-styling-classes-to-authori.patch (text/plain), 2.58 KB, created by Jonathan Druart on 2018-09-18 13:52:48 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Jonathan Druart

Created: 2018-09-18 13:52:48 UTC

Size: 2.58 KB

patch

obsolete

>From 8b6991f6d6991969be4134de16bc443a9845f432 Mon Sep 17 00:00:00 2001
>From: Jane Sandberg <sandbej@linnbenton.edu>
>Date: Sun, 16 Sep 2018 22:38:29 +0000
>Subject: [PATCH] Bug 13406: (follow-up) Add styling classes to authority MARC
> detail display
>
>Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>
>Amended patch: replace tab characters with spaces
>
>Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
>---
> authorities/detail.pl                                         | 11 ++++-------
> koha-tmpl/intranet-tmpl/prog/en/modules/authorities/detail.tt |  2 +-
> 2 files changed, 5 insertions(+), 8 deletions(-)
>
>diff --git a/authorities/detail.pl b/authorities/detail.pl
>index b2532385d9..908b7bdbb5 100755
>--- a/authorities/detail.pl
>+++ b/authorities/detail.pl
>@@ -139,16 +139,13 @@ sub build_tabs {
>                     }
>                     if ($#subfields_data>=0) {
>                       my %tag_data;
>-                      $tag_data{tag}=$field->tag(). ' '  
>-                                     . C4::Koha::display_marc_indicators($field) 
>-                                     . ' - '
>-                                     . $tagslib->{$field->tag()}->{lib};
>                       $tag_data{tag_number} = $tag;
>                       $tag_data{tag_desc} = $tagslib->{$field->tag()}->{lib};
>                       $tag_data{subfield} = \@subfields_data;
>-                      if ($tag >= 10){ # no indicator for theses tag
>-                            $tag_data{ind1} = $field->indicator(1);
>-                            $tag_data{ind2} = $field->indicator(2);
>+                      my $indicators = C4::Koha::display_marc_indicators($field);
>+                      if ( $indicators ) {
>+                          $tag_data{ind1} = substr $indicators, 0, 1;
>+                          $tag_data{ind2} = substr $indicators, 1, 1;
>                       }
> 
>                       push (@loop_data, \%tag_data);
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/authorities/detail.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/authorities/detail.tt
>index d121519326..00da448480 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/authorities/detail.tt
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/authorities/detail.tt
>@@ -62,7 +62,7 @@
> [% FOREACH BIG_LOO IN BIG_LOOP %]
>     <div id="tab[% BIG_LOO.number | html %]XX">
>     [% FOREACH innerloo IN BIG_LOO.innerloop %]
>-        [% IF ( innerloo.tag ) %]
>+        [% IF ( innerloo.tag_number ) %]
>             <div class="tag">
>             <div class="tag_title">
>                 <span class="tag_num">[% innerloo.tag_number | html %]</span>
>-- 
>2.11.0

Actions: View | Diff | Splinter Review

Attachments on bug 13406: 78995 | 78996 | 78999 | 79026 | 79053 | 79054 | 79117 | 79173