Attachment 79200 Details for Bug 21389 – Bug 21389: Correct Javascript error on article requests page

[patch] Bug 21389: Correct Javascript error on article requests page

Bug-21389-Correct-Javascript-error-on-article-requ.patch (text/plain), 1.97 KB, created by Fridolin Somers on 2018-09-21 09:24:43 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Fridolin Somers

Created: 2018-09-21 09:24:43 UTC

Size: 1.97 KB

patch

obsolete

>From 46be0204afd8be072c1716aef7c81b2aaf85ca7b Mon Sep 17 00:00:00 2001
>From: Fridolin Somers <fridolin.somers@biblibre.com>
>Date: Fri, 21 Sep 2018 11:17:25 +0200
>Subject: [PATCH] Bug 21389: Correct Javascript error on article requests page
>
>Bug 21076 fixed a Javascript error on article requests page when patron is found.
>
>There is also an error when patron is not found, with message :
>  Patron not found
>  No patron with this name, please, try another
>
>This patch fixes by replacing TT condition by a JS condition testing the existance of the patron input.
>
>Test plan:
>1 - Do not apply patch
>2 - Enable article requests
>3 - Search on staff client and click 'Request article'
>4 - Search for a patron that does not exist
>5 - You get a yellow message "Patron not found"
>6 - View error in console
>7 - Apply patch
>8 - Reload
>9 - Not error is gone
>10 - Search for a patron that does exist
>11 - Check there is no error in console
>12 - Check that autocompletion works
>---
> .../intranet-tmpl/prog/en/modules/circ/request-article.tt     | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/circ/request-article.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/circ/request-article.tt
>index f7772433dd..a8c0a1c549 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/circ/request-article.tt
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/circ/request-article.tt
>@@ -309,7 +309,7 @@
>         });
> 
>         $(document).ready(function() {
>-            [% UNLESS (patron ) %]
>+            if ( $( "#patron" ).size() ){
>                 $( "#patron" ).autocomplete({
>                     source: "/cgi-bin/koha/circ/ysearch.pl",
>                     minLength: 3,
>@@ -328,7 +328,7 @@
>                              item.country + "</small></a>" )
>                     .appendTo( ul );
>                 };
>-            [% END %]
>+            }
> 
>             $( ".ar-update-branchcode" ).on('focus', function(){
>                 previous_branchcode = this.value;
>-- 
>2.17.1

Actions: View | Diff | Splinter Review

Attachments on bug 21389: 79200 | 79226 | 80247