Attachment 79324 Details for Bug 15486 – Bug 15486: (follow-up) Default to unlimited

[patch] Bug 15486: (follow-up) Default to unlimited

Bug-15486-follow-up-Default-to-unlimited.patch (text/plain), 1.14 KB, created by Tomás Cohen Arazi (tcohen) on 2018-09-24 15:56:44 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Tomás Cohen Arazi (tcohen)

Created: 2018-09-24 15:56:44 UTC

Size: 1.14 KB

patch

obsolete

>From 42b697b1524885bfef2042b56e5033509236a078 Mon Sep 17 00:00:00 2001
>From: Tomas Cohen Arazi <tomascohen@theke.io>
>Date: Mon, 24 Sep 2018 12:56:07 -0300
>Subject: [PATCH] Bug 15486: (follow-up) Default to unlimited
>
>While it doesn't have a practical effect (the variable is reset several
>lines below) I agree this should be explicitly set to its default.
>
>Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
>---
> C4/Reserves.pm | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/C4/Reserves.pm b/C4/Reserves.pm
>index 5b97a298c5..19f8dd7046 100644
>--- a/C4/Reserves.pm
>+++ b/C4/Reserves.pm
>@@ -313,7 +313,7 @@ sub CanItemBeReserved {
>     my $ruleitemtype;    # itemtype of the matching issuing rule
>     my $allowedreserves  = 0; # Total number of holds allowed across all records
>     my $holds_per_record = 1; # Total number of holds allowed for this one given record
>-    my $holds_per_day    = 0; # Total number of holds allowed per day for the given patron
>+    my $holds_per_day;        # Default to unlimited
> 
>     # we retrieve borrowers and items informations #
>     # item->{itype} will come for biblioitems if necessery
>-- 
>2.19.0

Actions: View | Diff | Splinter Review

Attachments on bug 15486: 65128 | 65129 | 65130 | 65131 | 65132 | 65133 | 67202 | 67203 | 67204 | 67205 | 67206 | 67207 | 67337 | 67840 | 67841 | 67842 | 67843 | 67844 | 67845 | 68728 | 68729 | 68730 | 68731 | 68732 | 68733 | 68734 | 68735 | 68750 | 68751 | 68752 | 68791 | 71314 | 71315 | 71316 | 71317 | 71318 | 71319 | 72709 | 79318 | 79319 | 79320 | 79321 | 79322 | 79323 | 79324 | 79696 | 79697 | 79698 | 79699 | 79700 | 79701 | 79702 | 80478 | 80479 | 80480 | 80481 | 80482 | 80483 | 80484 | 81087