Bugzilla – Attachment 79358 Details for
Bug 21404
Remove unused variables in C4::Breeding->_auth_build_query
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 21404: Update test
Bug-21404-Update-test.patch (text/plain), 2.12 KB, created by
Josef Moravec
on 2018-09-25 07:07:15 UTC
(
hide
)
Description:
Bug 21404: Update test
Filename:
MIME Type:
Creator:
Josef Moravec
Created:
2018-09-25 07:07:15 UTC
Size:
2.12 KB
patch
obsolete
>From caa49b0e416ea8d7e60a2890174ece22321cc6fd Mon Sep 17 00:00:00 2001 >From: Josef Moravec <josef.moravec@gmail.com> >Date: Tue, 25 Sep 2018 06:33:02 +0000 >Subject: [PATCH] Bug 21404: Update test > >--- > t/db_dependent/Breeding.t | 10 +++++----- > 1 file changed, 5 insertions(+), 5 deletions(-) > >diff --git a/t/db_dependent/Breeding.t b/t/db_dependent/Breeding.t >index 65de56c..f226b2e 100644 >--- a/t/db_dependent/Breeding.t >+++ b/t/db_dependent/Breeding.t >@@ -55,13 +55,13 @@ subtest '_do_xslt_proc' => sub { > sub test_build_translate_query { > my $str; > #First pass no parameters >- my @queries= C4::Breeding::_build_query( {} ); >+ my @queries= C4::Breeding::_bib_build_query( {} ); > is( defined $queries[0] && $queries[0] eq '' && defined $queries[1] && >- $queries[1] eq '', 1, '_build_query gets no parameters'); >+ $queries[1] eq '', 1, '_bib_build_query gets no parameters'); > > #We now pass one parameter > my $pars1= { isbn => '234567' }; >- @queries= C4::Breeding::_build_query( $pars1 ); >+ @queries= C4::Breeding::_bib_build_query( $pars1 ); > #Passed only one par: zquery should start with @attr 1=\d+ > is( $queries[0] =~ /^\@attr 1=\d+/, 1, 'Z39.50 query with one parameter'); > $str=$pars1->{isbn}; >@@ -82,7 +82,7 @@ sub test_build_translate_query { > > #We now pass two parameters > my $pars2= { isbn => '123456', title => 'You should read this.' }; >- @queries= C4::Breeding::_build_query( $pars2 ); >+ @queries= C4::Breeding::_bib_build_query( $pars2 ); > #The Z39.50 query should start with @and (we passed two pars) > is( $queries[0] =~ /^\@and/, 1, 'Second Z39.50 query starts with @and'); > #We should also find two @attr 1=\d+ >@@ -104,7 +104,7 @@ sub test_build_translate_query { > > #We now pass a third wrong parameter (should not make a difference) > my $pars3= { isbn => '123456', title => 'You should read this.', xyz => 1 }; >- my @queries2= C4::Breeding::_build_query( $pars3 ); >+ my @queries2= C4::Breeding::_bib_build_query( $pars3 ); > is( $queries[0] eq $queries2[0] && $queries[1] eq $queries2[1], 1, > 'Third query makes no difference'); > >-- >2.1.4
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 21404
:
79357
|
79358
|
79359
|
79443
|
79444
|
79445
|
79492
|
79493
|
79494