Bugzilla – Attachment 79464 Details for
Bug 13272
Many inputs lack a type attribute
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 13272: Follow up add missing type="text"
Bug-13272-Follow-up-add-missing-typetext.patch (text/plain), 20.35 KB, created by
Mark Tompsett
on 2018-09-26 22:58:45 UTC
(
hide
)
Description:
Bug 13272: Follow up add missing type="text"
Filename:
MIME Type:
Creator:
Mark Tompsett
Created:
2018-09-26 22:58:45 UTC
Size:
20.35 KB
patch
obsolete
>From d8423daa55b7d3bb90c1b58e604cef1212d20507 Mon Sep 17 00:00:00 2001 >From: Mark Tompsett <mtompset@hotmail.com> >Date: Wed, 26 Sep 2018 22:57:32 +0000 >Subject: [PATCH] Bug 13272: Follow up add missing type="text" > >This addresses comment #13. >This also applies cleanly. >--- > koha-tmpl/intranet-tmpl/prog/en/includes/adv-search.inc | 4 ++-- > .../intranet-tmpl/prog/en/includes/cataloging-search.inc | 4 ++-- > .../intranet-tmpl/prog/en/includes/checkin-search.inc | 2 +- > koha-tmpl/intranet-tmpl/prog/en/includes/holds_table.inc | 2 +- > .../prog/en/modules/clubs/templates-add-modify.tt | 16 ++++++++-------- > .../prog/en/modules/serials/subscription-batchedit.tt | 2 +- > koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-basket.tt | 2 +- > koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-reserve.tt | 4 ++-- > koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-results.tt | 2 +- > .../opac-tmpl/bootstrap/en/modules/opac-shareshelf.tt | 2 +- > koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-shelves.tt | 4 ++-- > koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-user.tt | 4 ++-- > 12 files changed, 24 insertions(+), 24 deletions(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/includes/adv-search.inc b/koha-tmpl/intranet-tmpl/prog/en/includes/adv-search.inc >index 62bff05..5001346 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/includes/adv-search.inc >+++ b/koha-tmpl/intranet-tmpl/prog/en/includes/adv-search.inc >@@ -8,14 +8,14 @@ > <div id="checkin_search" class="residentsearch"> > <p class="tip">Scan a barcode to check in:</p> > <form method="post" action="/cgi-bin/koha/circ/returns.pl" autocomplete="off"> >- <input name="barcode" class="head-searchbox" id="ret_barcode" size="40" accesskey="r" /> >+ <input type="text" name="barcode" class="head-searchbox" id="ret_barcode" size="40" accesskey="r" /> > <input value="Submit" class="submit" type="submit" /> > </form> > </div> > <div id="renew_search" class="residentsearch"> > <p class="tip">Scan a barcode to renew:</p> > <form method="post" action="/cgi-bin/koha/circ/renew.pl" autocomplete="off"> >- <input class="head-searchbox" name="barcode" id="ren_barcode" size="40" /> >+ <input type="text" class="head-searchbox" name="barcode" id="ren_barcode" size="40" /> > <input value="Submit" class="submit" type="submit" /> > </form> > </div> >diff --git a/koha-tmpl/intranet-tmpl/prog/en/includes/cataloging-search.inc b/koha-tmpl/intranet-tmpl/prog/en/includes/cataloging-search.inc >index 35a496a..d979f69 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/includes/cataloging-search.inc >+++ b/koha-tmpl/intranet-tmpl/prog/en/includes/cataloging-search.inc >@@ -16,14 +16,14 @@ > <div id="checkin_search" class="residentsearch"> > <p class="tip">Scan a barcode to check in:</p> > <form method="post" action="/cgi-bin/koha/circ/returns.pl" autocomplete="off"> >- <input class="head-searchbox" name="barcode" id="ret_barcode" size="40" /> >+ <input class="head-searchbox" type="text" name="barcode" id="ret_barcode" size="40" /> > <input value="Submit" class="submit" type="submit" /> > </form> > </div> > <div id="renew_search" class="residentsearch"> > <p class="tip">Scan a barcode to renew:</p> > <form method="post" action="/cgi-bin/koha/circ/renew.pl" autocomplete="off"> >- <input class="head-searchbox" name="barcode" id="ren_barcode" size="40" /> >+ <input class="head-searchbox" type="text" name="barcode" id="ren_barcode" size="40" /> > <input value="Submit" class="submit" type="submit" /> > </form> > </div> >diff --git a/koha-tmpl/intranet-tmpl/prog/en/includes/checkin-search.inc b/koha-tmpl/intranet-tmpl/prog/en/includes/checkin-search.inc >index 05c5de6..f56af3e 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/includes/checkin-search.inc >+++ b/koha-tmpl/intranet-tmpl/prog/en/includes/checkin-search.inc >@@ -8,7 +8,7 @@ > <div id="renew_search" class="residentsearch"> > <p class="tip">Scan a barcode to renew:</p> > <form method="post" action="/cgi-bin/koha/circ/renew.pl" autocomplete="off"> >- <input class="head-searchbox" name="barcode" id="ren_barcode" size="40" /> >+ <input class="head-searchbox" type="text" name="barcode" id="ren_barcode" size="40" /> > <input value="Submit" class="submit" type="submit" /> > </form> > </div> >diff --git a/koha-tmpl/intranet-tmpl/prog/en/includes/holds_table.inc b/koha-tmpl/intranet-tmpl/prog/en/includes/holds_table.inc >index 2fd2d18..a04d1e0 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/includes/holds_table.inc >+++ b/koha-tmpl/intranet-tmpl/prog/en/includes/holds_table.inc >@@ -181,7 +181,7 @@ > > [% IF AutoResumeSuspendedHolds %] > <label for="suspend_until_[% hold.reserve_id | html %]">[% IF ( hold.suspend ) %] on [% ELSE %] until [% END %]</label> >- <input name="suspend_until" id="suspend_until_[% hold.reserve_id | html %]" size="10" value="[% hold.suspend_until | $KohaDates %]" class="datepicker suspend_until_datepicker" /> >+ <input type="text" name="suspend_until" id="suspend_until_[% hold.reserve_id | html %]" size="10" value="[% hold.suspend_until | $KohaDates %]" class="datepicker suspend_until_datepicker" /> > <a href='#' onclick="document.getElementById('suspend_until_[% hold.reserve_id | html %]').value='';">Clear date</a> > [% ELSE %] > <input type="hidden" name="suspend_until" id="suspend_until_[% hold.reserve_id | html %]" value=""/> >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/clubs/templates-add-modify.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/clubs/templates-add-modify.tt >index 2040c07..063c55a 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/clubs/templates-add-modify.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/clubs/templates-add-modify.tt >@@ -99,12 +99,12 @@ > <input type="hidden" name="club_template_field_id" value="[% f.id | html %]" /> > <li> > <label for="field-name-[% f.id | html %]">Name:</label> >- <input name="club_template_field_name" id="field-name-[% f.id | html %]" value="[% f.name | html %]" /> >+ <input type="text" name="club_template_field_name" id="field-name-[% f.id | html %]" value="[% f.name | html %]" /> > </li> > > <li> > <label for="field-description-[% f.id | html %]">Description:</label> >- <input name="club_template_field_description" id="field-description-[% f.id | html %]" value="[% f.description | html %]" /> >+ <input type="text" name="club_template_field_description" id="field-description-[% f.id | html %]" value="[% f.description | html %]" /> > </li> > > <li> >@@ -144,12 +144,12 @@ > <li> > <input type="hidden" name="club_template_enrollment_field_id" value="[% f.id | html %]" /> > <label for="enrollment-field-name-[% f.id | html %]">Name:</label> >- <input name="club_template_enrollment_field_name" id="enrollment-field-name-[% f.id | html %]" value="[% f.name | html %]" size="40" /> >+ <input type="text" name="club_template_enrollment_field_name" id="enrollment-field-name-[% f.id | html %]" value="[% f.name | html %]" size="40" /> > </li> > > <li> > <label for="enrollment-field-description-[% f.id | html %]">Description:</label> >- <input name="club_template_enrollment_field_description" id="enrollment-field-description-[% f.id | html %]" value="[% f.description | html %]" size="40" /> >+ <input type="text" name="club_template_enrollment_field_description" id="enrollment-field-description-[% f.id | html %]" value="[% f.description | html %]" size="40" /> > </li> > > <li> >@@ -193,12 +193,12 @@ > > <li> > <label for="club_template_field_name">Name:</label> >- <input name="club_template_field_name" /> >+ <input type="text" name="club_template_field_name" /> > </li> > > <li> > <label for="club_template_field_description">Description:</label> >- <input name="club_template_field_description" /> >+ <input type="text" name="club_template_field_description" /> > </li> > > <li> >@@ -220,12 +220,12 @@ > > <li> > <label for="club_template_enrollment_field_name">Name:</label> >- <input name="club_template_enrollment_field_name" /> >+ <input type="text" name="club_template_enrollment_field_name" /> > </li> > > <li> > <label for="club_template_enrollment_field_description">Description:</label> >- <input name="club_template_enrollment_field_description" /> >+ <input type="text" name="club_template_enrollment_field_description" /> > </li> > > <li> >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/serials/subscription-batchedit.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/serials/subscription-batchedit.tt >index b2e72a8..2880d77 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/serials/subscription-batchedit.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/serials/subscription-batchedit.tt >@@ -146,7 +146,7 @@ > [% END %] > </select> > [% ELSE %] >- <input id="field_[% field.id | html %]" name="field_[% field.id | html %]" placeholder="No change"/> >+ <input type="text" id="field_[% field.id | html %]" name="field_[% field.id | html %]" placeholder="No change"/> > [% END %] > </li> > [% END %] >diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-basket.tt b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-basket.tt >index 7533350..edb6ef4 100644 >--- a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-basket.tt >+++ b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-basket.tt >@@ -55,7 +55,7 @@ > [% IF ( TagsInputEnabled && loggedinusername ) %] > <span id="tagsel_form" style="display:none"> > <label for="tagsel_new">New tag:</label> >- <input name="tagsel_new" id="tagsel_new" maxlength="100" /> >+ <input type="text" name="tagsel_new" id="tagsel_new" maxlength="100" /> > <input id="tagsel_button" name="tagsel_button" class="input tagsel_button" title="Add" type="submit" value="Add"> > <a href="#" id="tagsel_cancel">Cancel</a> > </span> >diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-reserve.tt b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-reserve.tt >index aca8342..36f25d1 100644 >--- a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-reserve.tt >+++ b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-reserve.tt >@@ -260,14 +260,14 @@ > [% IF ( reserve_in_future ) %] > <li> > <label for="from[% bibitemloo.biblionumber | html %]">Hold starts on date:</label> >- <input name="reserve_date_[% bibitemloo.biblionumber | html %]" id="from[% bibitemloo.biblionumber | html %]" size="10" class="holddatefrom"/> >+ <input type="text" name="reserve_date_[% bibitemloo.biblionumber | html %]" id="from[% bibitemloo.biblionumber | html %]" size="10" class="holddatefrom"/> > <span class="date-format from" data-biblionumber="[% bibitemloo.biblionumber | html %]">[% INCLUDE 'date-format.inc' %]</span> > </li> > [% END %] > > <li> > <label for="to[% bibitemloo.biblionumber | html %]">Hold not needed after:</label> >- <input name="expiration_date_[% bibitemloo.biblionumber | html %]" id="to[% bibitemloo.biblionumber | html %]" size="10" class="holddateto" /> >+ <input type="text" name="expiration_date_[% bibitemloo.biblionumber | html %]" id="to[% bibitemloo.biblionumber | html %]" size="10" class="holddateto" /> > <span class="date-format to" data-biblionumber="[% bibitemloo.biblionumber | html %]">[% INCLUDE 'date-format.inc' %]</span> > </li> > >diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-results.tt b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-results.tt >index afaa775..b4a417f 100644 >--- a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-results.tt >+++ b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-results.tt >@@ -169,7 +169,7 @@ > </span> > <div id="tagsel_form" style="display:none"> > <label for="tagsel_new">New tag:</label> >- <input name="tagsel_new" id="tagsel_new" maxlength="100" /> >+ <input type="text" name="tagsel_new" id="tagsel_new" maxlength="100" /> > <input id="tagsel_button" name="tagsel_button" class="tagsel_button btn btn-small" title="Add" type="submit" value="Add" /> > <a href="#" id="tagsel_cancel">(done)</a> > </div> >diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-shareshelf.tt b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-shareshelf.tt >index 6963588..6bfd1b4 100644 >--- a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-shareshelf.tt >+++ b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-shareshelf.tt >@@ -55,7 +55,7 @@ > <li><label for="name">List name:</label> [% shelfname | html %]</li> > <li> > <label for="invite_address">Email address:</label> >- <input id="invite_address" name="invite_address" size="40" /> >+ <input type="text" id="invite_address" name="invite_address" size="40" /> > </li> > </ol> > </fieldset> >diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-shelves.tt b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-shelves.tt >index 34b7201..dae56ed 100644 >--- a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-shelves.tt >+++ b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-shelves.tt >@@ -270,7 +270,7 @@ > </span> > <span id="tagsel_form" style="display:none"> > <label for="tagsel_new">New tag(s), separated by a comma:</label> >- <input name="tagsel_new" id="tagsel_new" maxlength="100" /> >+ <input type="text" name="tagsel_new" id="tagsel_new" maxlength="100" /> > <input id="tagsel_button" name="tagsel_button" class="tagsel_button btn btn-small" title="tagsel_button" type="submit" value="Add" /> > <a href="#" id="tagsel_cancel">Cancel</a> > </span> >@@ -456,7 +456,7 @@ > <span class="actions"><a class="tag_add hidden" id="tag_add[% itemsloo.biblionumber | html %]" href="#">Add tag</a></span> > <div id="tagform[% itemsloo.biblionumber | html %]" class="tag_results_input" style="display:none;"> > <label for="newtag[% itemsloo.biblionumber | html %]">New tag(s), separated by a comma:</label> >- <input name="newtag[% itemsloo.biblionumber | html %]" id="newtag[% itemsloo.biblionumber | html %]" maxlength="100" /> >+ <input type="text" name="newtag[% itemsloo.biblionumber | html %]" id="newtag[% itemsloo.biblionumber | html %]" maxlength="100" /> > <input name="tagbutton" class="tagbutton btn btn-small" title="[% itemsloo.biblionumber | html %]" type="submit" value="Add" /> > <a class="cancel_tag_add" id="cancel[% itemsloo.biblionumber | html %]" href="#">(done)</a> > </div> >diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-user.tt b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-user.tt >index 728ddaf..69ce9b0 100644 >--- a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-user.tt >+++ b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-user.tt >@@ -723,7 +723,7 @@ > <div class="modal-body"> > <input type="hidden" name="reserve_id" value="[% RESERVE.reserve_id | html %]" /> > <label for="suspend_until_[% RESERVE.reserve_id | html %]">Suspend until:</label> >- <input name="suspend_until" id="suspend_until_[% RESERVE.reserve_id | html %]" class="suspend-until" size="10" /> >+ <input type="text" name="suspend_until" id="suspend_until_[% RESERVE.reserve_id | html %]" class="suspend-until" size="10" /> > [% INCLUDE 'date-format.inc' %] > <p class="js-show"><a href="#" onclick="document.getElementById('suspend_until_[% RESERVE.reserve_id | html %]').value='';return false;">Clear date to suspend indefinitely</a></p> > <button class="btn btn-mini js-hide" type="submit" name="submit">Suspend</button> >@@ -765,7 +765,7 @@ > > [% IF AutoResumeSuspendedHolds %] > <label for="suspend_until"> until </label> >- <input name="suspend_until" id="suspend_until" class="suspend-until" readonly="readonly" size="10" /> >+ <input type="text" name="suspend_until" id="suspend_until" class="suspend-until" readonly="readonly" size="10" /> > <a href="#" style="font-size:85%;text-decoration:none;" onclick="document.getElementById('suspend_until').value='';return false;">Clear date to suspend indefinitely</a> > [% END %] > </form> >-- >2.1.4
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 13272
:
79018
|
79120
|
79123
|
79162
|
79163
|
79164
|
79333
|
79464
|
79593
|
79594
|
79595
|
79596
|
79622
|
79623
|
79624
|
79625