Bugzilla – Attachment 79468 Details for
Bug 21398
Search term when adding an order from an existing record should be required
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 21398: Make search field mandatory when adding to a basket from an existing record
Bug-21398-Make-search-field-mandatory-when-adding-.patch (text/plain), 1.62 KB, created by
Martin Renvoize (ashimema)
on 2018-09-27 08:01:24 UTC
(
hide
)
Description:
Bug 21398: Make search field mandatory when adding to a basket from an existing record
Filename:
MIME Type:
Creator:
Martin Renvoize (ashimema)
Created:
2018-09-27 08:01:24 UTC
Size:
1.62 KB
patch
obsolete
>From f84f6b2b091ad428797a19b40ecf502b47d59b3f Mon Sep 17 00:00:00 2001 >From: Jonathan Druart <jonathan.druart@bugs.koha-community.org> >Date: Sat, 22 Sep 2018 11:08:16 -0300 >Subject: [PATCH] Bug 21398: Make search field mandatory when adding to a > basket from an existing record > >Test plan: >- Create a basket >- Click the "Add to basket" button >- Click "Search" on the first line >=> Without this patch you get an ugly screen: https://snag.gy/U8X3ZK.jpg >=> With this patch applied you will not be able to submit without >filling the input in > >QA note: Yes, we could handle that controller side as well, but much >more work. > >Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> >--- > .../prog/en/includes/acquisitions-add-to-basket.inc | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/includes/acquisitions-add-to-basket.inc b/koha-tmpl/intranet-tmpl/prog/en/includes/acquisitions-add-to-basket.inc >index 64234df6be..0bf441824c 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/includes/acquisitions-add-to-basket.inc >+++ b/koha-tmpl/intranet-tmpl/prog/en/includes/acquisitions-add-to-basket.inc >@@ -5,7 +5,7 @@ > <li> > <form action="/cgi-bin/koha/acqui/neworderbiblio.pl" method="post"> > <label>From an existing record: >- <input type="text" size="25" name="q" /> >+ <input type="text" size="25" name="q" required="required"/> > </label> > <input type="hidden" name="booksellerid" value="[% booksellerid | html %]" /> > <input type="hidden" name="basketno" value="[% basketno | html %]" /> >-- >2.18.0
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 21398
:
79265
|
79468
|
79473