Attachment 79497 Details for Bug 20797 – Bug 20797: (follow-up) Conditionally link

[patch] Bug 20797: (follow-up) Conditionally link

Bug-20797-follow-up-Conditionally-link.patch (text/plain), 1.42 KB, created by Magnus Enger on 2018-09-27 12:41:12 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Magnus Enger

Created: 2018-09-27 12:41:12 UTC

Size: 1.42 KB

patch

obsolete

>From 90058d08e41967eb29a03e8a6fa23c56d451c6a0 Mon Sep 17 00:00:00 2001
>From: Andrew Isherwood <andrew.isherwood@ptfs-europe.com>
>Date: Thu, 7 Jun 2018 11:14:50 +0100
>Subject: [PATCH] Bug 20797: (follow-up) Conditionally link
>
>We don't want to display the link to the biblio if the biblio_id is null
>
>Signed-off-by: Magnus Enger <magnus@enger.priv.no>
>Works as advertised. The link is only displayed if there is a
>biblionumber to link to.
>---
> koha-tmpl/intranet-tmpl/prog/en/modules/ill/ill-requests.tt | 5 +++--
> 1 file changed, 3 insertions(+), 2 deletions(-)
>
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/ill/ill-requests.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/ill/ill-requests.tt
>index 0763ba8552..7e503b8cc6 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/ill/ill-requests.tt
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/ill/ill-requests.tt
>@@ -118,11 +118,12 @@
> 
>         // Our 'render' function for biblio_id
>         var createBiblioLink = function(data, type, row) {
>-            return '<a title="' + _("View biblio details") + '" ' +
>+            return (row.biblio_id) ?
>+                '<a title="' + _("View biblio details") + '" ' +
>                 'href="/cgi-bin/koha/catalogue/detail.pl?biblionumber=' +
>                 row.biblio_id + '">' +
>                 row.biblio_id +
>-                '</a>';
>+                '</a>' : '';
>         };
> 
>         // Our 'render' function for the library name
>-- 
>2.11.0

Actions: View | Diff | Splinter Review

Attachments on bug 20797: 75454 | 75485 | 75486 | 75656 | 75870 | 79495 | 79496 | 79497 | 79578 | 79579 | 79580 | 79581 | 79582 | 79946 | 79947 | 80018 | 80019 | 80021 | 80022 | 80038 | 80040 | 80047 | 80048 | 80049 | 80055 | 80071 | 80072 | 80073 | 80120 | 80121 | 80122