Bugzilla – Attachment 79561 Details for
Bug 19625
Shibboleth auto-provisioning is broken in plack
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 19625: Enable Shibboleth auto-provisioning for Plack
Bug-19625-Enable-Shibboleth-auto-provisioning-for-.patch (text/plain), 1.64 KB, created by
Martin Renvoize (ashimema)
on 2018-09-28 09:13:11 UTC
(
hide
)
Description:
Bug 19625: Enable Shibboleth auto-provisioning for Plack
Filename:
MIME Type:
Creator:
Martin Renvoize (ashimema)
Created:
2018-09-28 09:13:11 UTC
Size:
1.64 KB
patch
obsolete
>From ecdaded139079144900bd256f7d8ba223902990d Mon Sep 17 00:00:00 2001 >From: Matthias Meusburger <matthias.meusburger@biblibre.com> >Date: Wed, 15 Nov 2017 10:50:27 +0000 >Subject: [PATCH] Bug 19625: Enable Shibboleth auto-provisioning for Plack > >Test plan: >1. In $KOHA_CONF, check that //shibboleth/autocreate is set to 1 >2. Find a user in Shibboleth that is not in Koha (or remove it from > Koha) >3. Login with that user >4. Verify that the userid is not set correctly in Koha database >5. Apply the patch (restart starman) >6. Repeat steps 2 and 3 >7. Verify that the userid is set correctly and the other >mapped fields if there are some > >Signed-off-by: Julian Maurice <julian.maurice@biblibre.com> >Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> >--- > C4/Auth_with_shibboleth.pm | 6 +++++- > 1 file changed, 5 insertions(+), 1 deletion(-) > >diff --git a/C4/Auth_with_shibboleth.pm b/C4/Auth_with_shibboleth.pm >index f855ae1bdf..b81526964f 100644 >--- a/C4/Auth_with_shibboleth.pm >+++ b/C4/Auth_with_shibboleth.pm >@@ -119,7 +119,11 @@ sub _autocreate { > my %borrower = ( $config->{matchpoint} => $match ); > > while ( my ( $key, $entry ) = each %{$config->{'mapping'}} ) { >- $borrower{$key} = ( $entry->{'is'} && $ENV{ $entry->{'is'} } ) || $entry->{'content'} || ''; >+ if ( any { /(^psgi|^plack)/i } keys %ENV ) { >+ $borrower{$key} = ( $entry->{'is'} && $ENV{"HTTP_" . uc($entry->{'is'}) } ) || $entry->{'content'} || ''; >+ } else { >+ $borrower{$key} = ( $entry->{'is'} && $ENV{ $entry->{'is'} } ) || $entry->{'content'} || ''; >+ } > } > > my $patron = Koha::Patron->new( \%borrower )->store; >-- >2.18.0
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 19625
:
69151
|
79467
| 79561