Attachment 79592 Details for Bug 20996 – Bug 20996: (follow-up) Fix column name expectation

[patch] Bug 20996: (follow-up) Fix column name expectation

Bug-20996-follow-up-Fix-column-name-expectation.patch (text/plain), 2.22 KB, created by Magnus Enger on 2018-09-28 13:30:00 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Magnus Enger

Created: 2018-09-28 13:30:00 UTC

Size: 2.22 KB

patch

obsolete

>From fbcb59862e99a6470ef977c809bfb44b3417351c Mon Sep 17 00:00:00 2001
>From: Andrew Isherwood <andrew.isherwood@ptfs-europe.com>
>Date: Fri, 28 Sep 2018 13:44:16 +0100
>Subject: [PATCH] Bug 20996: (follow-up) Fix column name expectation
>
>This bug changes how request metadata is obtained. Previously the
>appropriate backend's metadata function would return it. For at least
>the FreeForm backend, the metadata property names we title cased. The
>datatable JS was expecting this and breaks with the new metadata getting
>which is performed in the API controller, which just returns the
>property names as they appear in the DB.
>
>This patch changes the expectation of the JS to match what's coming back
>from the API
>
>Signed-off-by: Magnus Enger <magnus@enger.priv.no>
>Tested by repeatedly loading the API-call
>http://intranet/api/v1/illrequests?embed=metadata,patron,capabilities,library
>in Chromium and watching the reported time to load the URL. There
>is a siginificant decrease in the time with the patches compared to
>the time it takes without the patches. I had some concerns along the
>way, but they have all been fixed.
>
>Signed-off-by: Magnus Enger <magnus@libriotech.no>
>Tested by repeatedly loading the API-call
>http://intranet/api/v1/illrequests?embed=metadata,patron,capabilities,library
>in Chromium and watching the reported time to load the URL. There
>is a siginificant decrease in the time with the patches compared to
>the time it takes without the patches. I had some concerns along the
>way, but they have all been fixed.
>---
> koha-tmpl/intranet-tmpl/prog/en/modules/ill/ill-requests.tt | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/ill/ill-requests.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/ill/ill-requests.tt
>index 19f4289a95..3dcdb8e357 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/ill/ill-requests.tt
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/ill/ill-requests.tt
>@@ -43,8 +43,8 @@
> 
>         // The core fields that should be displayed first
>         var core = [
>-            'metadata_Author',
>-            'metadata_Title',
>+            'metadata_author',
>+            'metadata_title',
>             'borrowername',
>             'biblio_id',
>             'library',
>-- 
>2.11.0

Actions: View | Diff | Splinter Review

Attachments on bug 20996: 76687 | 76688 | 76705 | 77100 | 79379 | 79576 | 79583 | 79584 | 79585 | 79586 | 79587 | 79588 | 79589 | 79590 | 79591 | 79592 | 81715 | 81716 | 81717 | 81718 | 81719 | 81720 | 81747 | 81748 | 81749 | 81750 | 81751 | 81752 | 81753 | 81755 | 81756 | 81757 | 81758 | 81759 | 81760 | 81761 | 81908 | 81909 | 81928 | 81967 | 81994 | 81996 | 81997 | 81998