Bugzilla – Attachment 79787 Details for
Bug 21448
Field 606 doesn't add multiple x subfields
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 21448: Fix copy repeated subfields when linking an authority with 6xx
Bug-21448-Fix-copy-repeated-subfields-when-linking.patch (text/plain), 1.75 KB, created by
Chris Cormack
on 2018-10-01 22:02:02 UTC
(
hide
)
Description:
Bug 21448: Fix copy repeated subfields when linking an authority with 6xx
Filename:
MIME Type:
Creator:
Chris Cormack
Created:
2018-10-01 22:02:02 UTC
Size:
1.75 KB
patch
obsolete
>From 574a14b298c25b0691593695c3896c05657168fd Mon Sep 17 00:00:00 2001 >From: Jonathan Druart <jonathan.druart@bugs.koha-community.org> >Date: Sat, 29 Sep 2018 16:04:56 -0300 >Subject: [PATCH] Bug 21448: Fix copy repeated subfields when linking an > authority with 6xx >MIME-Version: 1.0 >Content-Type: text/plain; charset=UTF-8 >Content-Transfer-Encoding: 8bit > >The reported issue was: >On field 606, if I use an Authority with multiple "x" subfields, it will >add just the first "x" > >Error in the logs: >Odd number of elements in anonymous hash at /home/vagrant/kohaclone/authorities/blinddetail-biblio-search.pl line 97. > >We should pass a ref (!), caused by > commit a7df1f9f8eb9ed16246964d94dd8a69b756b6551 > Bug 18904: (follow-up) Retrieve subfield in the order they are stored > >Test plan: >Edit an authority and add several $x to 600 >Link this authority to a bibliographic record >=> Without this patch only the first subfield is copied >=> With this patch applied they are all copied > >Signed-off-by: José Anjos <joseanjos@gmail.com> >Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz> >--- > authorities/blinddetail-biblio-search.pl | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > >diff --git a/authorities/blinddetail-biblio-search.pl b/authorities/blinddetail-biblio-search.pl >index f8ae22b242..73d2fcf160 100755 >--- a/authorities/blinddetail-biblio-search.pl >+++ b/authorities/blinddetail-biblio-search.pl >@@ -94,7 +94,7 @@ if ($authid) { > $letter ||= '@'; > next if defined $done_subfields{$letter}; > my @values = $field->subfield($letter); >- push @subfield_loop, {marc_subfield => $letter, marc_values => @values }; >+ push @subfield_loop, {marc_subfield => $letter, marc_values => \@values }; > $done_subfields{$letter} = 1; > } > >-- >2.11.0
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 21448
:
79620
|
79710
| 79787