Attachment 79832 Details for Bug 21418 – Bug 21418: Remove shelfoff which is not used

[patch] Bug 21418: Remove shelfoff which is not used

Bug-21418-Remove-shelfoff-which-is-not-used.patch (text/plain), 1.65 KB, created by Josef Moravec on 2018-10-02 16:42:55 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Josef Moravec

Created: 2018-10-02 16:42:55 UTC

Size: 1.65 KB

patch

obsolete

>From a05bdd7c74e1c33b6f56e6b15aa48ba6c9e2f90d Mon Sep 17 00:00:00 2001
>From: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
>Date: Sat, 29 Sep 2018 11:26:25 -0300
>Subject: [PATCH] Bug 21418: Remove shelfoff which is not used
>
>No need to add a new line to escape this variable that is never used,
>better to remove it
>
>`git grep shelfoff` will prove that it is not used anywhere else.
>
>Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
>
>Signed-off-by: Owen Leonard <oleonard@myacpl.org>
>
>Signed-off-by: Josef Moravec <josef.moravec@gmail.com>
>---
> .../prog/en/modules/virtualshelves/tables/shelves_results.tt             | 1 -
> 1 file changed, 1 deletion(-)
>
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/virtualshelves/tables/shelves_results.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/virtualshelves/tables/shelves_results.tt
>index db4ed8e..66452ff7 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/virtualshelves/tables/shelves_results.tt
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/virtualshelves/tables/shelves_results.tt
>@@ -47,7 +47,6 @@
>     [%~ END ~%]
>     [%~ IF can_manage_shelf OR can_delete_shelf ~%]
>         [%~ action_block = action_block _ ' <form action="shelves.pl" method="post">' ~%]
>-        [%~ action_block = action_block _ '<input type="hidden" name="shelfoff" value="' _ shelfoff _ '" />' ~%]
>         [%~ action_block = action_block _ '<input type="hidden" name="shelves" value="1" />' ~%]
>         [%~ action_block = action_block _ '<input type="hidden" name="op" value="delete" />' ~%]
>         [%~ action_block = action_block _ '<input type="hidden" name="shelfnumber" value="' _ shelfnumber  _ '" />' ~%]
>-- 
>2.1.4

Actions: View | Diff | Splinter Review

Attachments on bug 21418: 79442 | 79610 | 79611 | 79612 | 79706 | 79707 | 79830 | 79831 | 79832