Attachment 79847 Details for Bug 21322 – Bug 21322: process_message_queue.pl --type should take an argument

[patch] Bug 21322: process_message_queue.pl --type should take an argument

Bug-21322-processmessagequeuepl---type-should-take.patch (text/plain), 1.45 KB, created by Josef Moravec on 2018-10-02 17:39:51 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Josef Moravec

Created: 2018-10-02 17:39:51 UTC

Size: 1.45 KB

patch

obsolete

>From 24042ddecf5f7819285de3796f9492315c060990 Mon Sep 17 00:00:00 2001
>From: Magnus Enger <magnus@libriotech.no>
>Date: Thu, 6 Sep 2018 13:23:17 +0000
>Subject: [PATCH] Bug 21322: process_message_queue.pl --type should take an
> argument
>
>The help for this script says:
>-t --type: If supplied, only processes this type of message ( email, sms )
>
>Currently, the type argument is set up wrong, so it does not look
>for an argument. This patch fixes that.
>
>To test, run this command (should work in kohadevbox) or something
>similar:
>
>$ sudo koha-shell -c "perl \
>/home/vagrant/kohaclone/misc/cronjobs/process_message_queue.pl -v \
>--type=sms" kohadev
>
>This should give the following error: "Option type does not take an argument".
>Apply the patch and run the same command again. This should not give an
>error.
>
>Signed-off-by: Mark Tompsett <mtompset@hotmail.com>
>
>Signed-off-by: Josef Moravec <josef.moravec@gmail.com>
>---
> misc/cronjobs/process_message_queue.pl | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/misc/cronjobs/process_message_queue.pl b/misc/cronjobs/process_message_queue.pl
>index 93f5c35..3e0ef51 100755
>--- a/misc/cronjobs/process_message_queue.pl
>+++ b/misc/cronjobs/process_message_queue.pl
>@@ -44,7 +44,7 @@ GetOptions(
>     'm|method:s'        => \$method,
>     'h|help|?'          => \$help,
>     'v|verbose'         => \$verbose,
>-    't|type'            => \$type,
>+    't|type:s'          => \$type,
> );
> my $usage = << 'ENDUSAGE';
> 
>-- 
>2.1.4

Actions: View | Diff | Splinter Review

Attachments on bug 21322: 78476 | 78492 | 79406 | 79847