Bugzilla – Attachment 79860 Details for
Bug 21480
misc/translator/translate does not work with perl 5.26
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
0001-Bug-21480-misc-translator-translate-does-not-work-wi.patch
0001-Bug-21480-misc-translator-translate-does-not-work-wi.patch (text/plain), 2.80 KB, created by
Olli-Antti Kivilahti
on 2018-10-03 08:52:27 UTC
(
hide
)
Description:
0001-Bug-21480-misc-translator-translate-does-not-work-wi.patch
Filename:
MIME Type:
Creator:
Olli-Antti Kivilahti
Created:
2018-10-03 08:52:27 UTC
Size:
2.80 KB
patch
obsolete
>From e935c4c25fe5bb262daac394efcbdfdf4a56939f Mon Sep 17 00:00:00 2001 >From: Olli-Antti Kivilahti <olli-antti.kivilahti@helsinki.fi> >Date: Wed, 3 Oct 2018 11:24:38 +0300 >Subject: [PATCH] Bug 21480 - misc/translator/translate does not work with perl > 5.26 > >Perl 5.26 (or earlier) introduced a security feature, where implicitly >including the program directory as a Perl library directory no longer >happens (perl -I. ). > >This causes translate to fail because it cannot find the *.pm -files in it's >own directory. > >This patch adds the familiar mantra > use lib $FindBin::Bin; >to the relevant scripts. > >To test: > >1. Install Ubuntu18.04 or something else with Perl 5.26 >2. Install Koha (we use the dev-install) >3. cd $KOHA_PATH/misc/trnaslator/ >4. perl translate create fi-FI >5. Observe problems with missing modules. >--- > misc/translator/text-extract.pl | 4 ++++ > misc/translator/text-extract2.pl | 3 +++ > misc/translator/tmpl_process3.pl | 3 +++ > misc/translator/translate | 3 +++ > misc/translator/xgettext.pl | 3 +++ > 5 files changed, 16 insertions(+) > >diff --git a/misc/translator/text-extract.pl b/misc/translator/text-extract.pl >index 4e2fbdc..10d3520 100755 >--- a/misc/translator/text-extract.pl >+++ b/misc/translator/text-extract.pl >@@ -1,6 +1,10 @@ > #!/usr/bin/perl > #use strict; > #use warnings; FIXME - Bug 2505 >+ >+use FindBin; >+use lib $FindBin::Bin; >+ > use HTML::Tree; > use Getopt::Std; > getopt("f:"); >diff --git a/misc/translator/text-extract2.pl b/misc/translator/text-extract2.pl >index cfcd027..f7a5c83 100755 >--- a/misc/translator/text-extract2.pl >+++ b/misc/translator/text-extract2.pl >@@ -14,6 +14,9 @@ > # --> This will be relatively major rework, and requires corresponding > # rework in tmpl_process.pl > >+use FindBin; >+use lib $FindBin::Bin; >+ > use strict; > #use warnings; FIXME - Bug 2505 > use Getopt::Long; >diff --git a/misc/translator/tmpl_process3.pl b/misc/translator/tmpl_process3.pl >index 4ded16f..e39e64c 100755 >--- a/misc/translator/tmpl_process3.pl >+++ b/misc/translator/tmpl_process3.pl >@@ -4,6 +4,9 @@ > # Parts copyright 2003-2004 Jerome Vizcaino > # Parts copyright 2004 Ambrose Li > >+use FindBin; >+use lib $FindBin::Bin; >+ > =head1 NAME > > tmpl_process3.pl - Alternative version of tmpl_process.pl >diff --git a/misc/translator/translate b/misc/translator/translate >index 697a3db..59a0c12 100755 >--- a/misc/translator/translate >+++ b/misc/translator/translate >@@ -19,6 +19,9 @@ > > package Main; > >+use FindBin; >+use lib $FindBin::Bin; >+ > use strict; > use warnings; > >diff --git a/misc/translator/xgettext.pl b/misc/translator/xgettext.pl >index 8d55547..508fd87 100755 >--- a/misc/translator/xgettext.pl >+++ b/misc/translator/xgettext.pl >@@ -6,6 +6,9 @@ xgettext.pl - xgettext(1)-like interface for .tt strings extraction > > =cut > >+use FindBin; >+use lib $FindBin::Bin; >+ > use strict; > use warnings; > use Getopt::Long; >-- >2.17.1 >
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 21480
:
79860
|
79861
|
79901