Bugzilla – Attachment 7996 Details for
Bug 6473
Test bug for Git-bz ✔ ❤ ★
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 7582 - When adding a Z39.50 server the "checked" option should use a checkbox
Bug-7582---When-adding-a-Z3950-server-the-checked-.patch (text/plain), 4.71 KB, created by
Liz Rea
on 2012-03-02 20:51:59 UTC
(
hide
)
Description:
Bug 7582 - When adding a Z39.50 server the "checked" option should use a checkbox
Filename:
MIME Type:
Creator:
Liz Rea
Created:
2012-03-02 20:51:59 UTC
Size:
4.71 KB
patch
obsolete
>From 6695bc82da4d07971b827fef51bc74816bdc6d53 Mon Sep 17 00:00:00 2001 >From: Owen Leonard <oleonard@myacpl.org> >Date: Wed, 22 Feb 2012 12:24:54 -0500 >Subject: [PATCH] Bug 7582 - When adding a Z39.50 server the "checked" option should use a checkbox >Content-Type: text/plain; charset="utf-8" > >Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com> >Signed-off-by: Paul Poulain <paul.poulain@biblibre.com> > >http://bugs.koha-community.org/show_bug.cgi?id=6473 >--- > admin/z3950servers.pl | 3 ++- > .../prog/en/modules/admin/z3950servers.tt | 12 ++++++++---- > 2 files changed, 10 insertions(+), 5 deletions(-) > >diff --git a/admin/z3950servers.pl b/admin/z3950servers.pl >index 44b3967..f0a4dbb 100755 >--- a/admin/z3950servers.pl >+++ b/admin/z3950servers.pl >@@ -91,6 +91,7 @@ if ($op eq 'add_form') { > my $dbh=C4::Context->dbh; > my $sth=$dbh->prepare("select * from z3950servers where name=?"); > $sth->execute($input->param('searchfield')); >+ my $checked = $input->param('checked') ? 1 : 0; > if ($sth->rows) { > $sth=$dbh->prepare("update z3950servers set host=?, port=?, db=?, userid=?, password=?, name=?, checked=?, rank=?,syntax=?,encoding=? where name=?"); > $sth->execute($input->param('host'), >@@ -99,7 +100,7 @@ if ($op eq 'add_form') { > $input->param('userid'), > $input->param('password'), > $input->param('searchfield'), >- $input->param('checked'), >+ $checked, > $input->param('rank'), > $input->param('syntax'), > $input->param('encoding'), >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/z3950servers.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/z3950servers.tt >index e565acf..12585b3 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/z3950servers.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/z3950servers.tt >@@ -57,8 +57,6 @@ > } > if (isNaN(f.rank.value)) {_alertString += "- rank must be a number\n"; > } >- if (isNaN(f.checked.value) || f.checked.value<0 || f.checked.value>1) {_alertString += "- checked must be 0 or 1\n"; >- } > if (_alertString.length==0) {document.Aform.submit(); > } else {alertString2 = "Form not submitted because of the following problem(s)\n";alertString2 += "------------------------------------------------------------------------------------\n\n";alertString2 += _alertString;alert(alertString2); > } >@@ -109,7 +107,13 @@ > </li> > <li><label for="password">Password: </label> <input type="text" name="password" id="password" value="[% password %]" /> > </li> >- <li><label for="checked">Checked (searched by default): </label> <input type="text" size="1" name="checked" id="checked" value="[% checked %]" onblur="isNum(this)" /> </li> >+ <li><label for="checked">Checked (searched by default): </label> >+ [% IF ( checked ) %] >+ <input type="checkbox" name="checked" id="checked" value="1" checked="checked" /> >+ [% ELSE %] >+ <input type="checkbox" name="checked" id="checked" value="1" /> >+ [% END %] >+ </li> > <li><label for="rank">Rank (display order): </label> <input type="text" name="rank" id="rank" size="4" value="[% rank %]" onblur="isNum(this)" /> > </li> > <li><label for="syntax">Syntax (z3950 can send<br /> records in various format. Choose one): </label> >@@ -305,7 +309,7 @@ > [% ELSE %] > <tr> > [% END %] >-<td><a href="[% loo.script_name %]?op=add_form&searchfield=[% loo.name |url %]">[% loo.name %]</a></td><td>[% loo.host %]:[% loo.port %]</td><td>[% loo.db %]</td><td>[% loo.userid %]</td><td>[% loo.password %]</td><td>[% loo.checked %]</td><td>[% loo.rank %]</td> <td>[% loo.syntax %]</td><td>[% loo.encoding %]</td><td><a href="[% loo.script_name %]?op=add_form&searchfield=[% loo.name |url %]">Edit</a></td><td><a href="[% loo.script_name %]?op=delete_confirm&searchfield=[% loo.name |url %]">Delete</a></td> </tr> >+<td><a href="[% loo.script_name %]?op=add_form&searchfield=[% loo.name |url %]">[% loo.name %]</a></td><td>[% loo.host %]:[% loo.port %]</td><td>[% loo.db %]</td><td>[% loo.userid %]</td><td>[% loo.password %]</td><td>[% IF ( loo.checked ) %]Yes[% ELSE %]No[% END %]</td><td>[% loo.rank %]</td> <td>[% loo.syntax %]</td><td>[% loo.encoding %]</td><td><a href="[% loo.script_name %]?op=add_form&searchfield=[% loo.name |url %]">Edit</a></td><td><a href="[% loo.script_name %]?op=delete_confirm&searchfield=[% loo.name |url %]">Delete</a></td> </tr> > [% END %]</tbody> > </table> > >-- >1.7.2.5
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 6473
:
4386
|
6837
|
6838
|
6839
|
6840
|
6841
|
6842
|
6843
|
7154
|
7155
|
7567
|
7994
|
7995
|
7996
|
7997
|
8018
|
9807
|
9808
|
9813
|
9831
|
9832
|
9836
|
9854
|
10842
|
10843
|
10844
|
10845
|
10846
|
10847
|
10848
|
10849
|
10850
|
10851
|
10852
|
10853
|
10854
|
10855
|
10856
|
10857
|
10858
|
11540
|
11543
|
11544
|
12502
|
12513
|
12514
|
12515
|
12516
|
12517
|
12518
|
12519
|
13473
|
13673
|
14955
|
14969
|
14970
|
14972
|
15201
|
18949
|
18950
|
18951
|
18952
|
18953
|
18954
|
18955
|
18956
|
18957
|
18958
|
18959
|
18960
|
18961
|
18962
|
18963
|
18971
|
18972
|
19518
|
19519
|
19591
|
19592
|
19871
|
19879
|
19880
|
19881
|
19882
|
20011
|
20012
|
20013
|
20014
|
22477
|
22481
|
22482
|
22496
|
22502
|
22503
|
31958
|
32444
|
32445
|
32446
|
32447
|
32448
|
32449
|
32450
|
32451
|
32452
|
34200
|
34201
|
34625
|
34999
|
35130
|
35269
|
35273
|
35274
|
35275
|
35276
|
35277
|
35279
|
35280
|
35303
|
40954
|
40957
|
45345
|
45349
|
45731
|
45732
|
45733
|
45734
|
47283
|
47284
|
47298
|
47299
|
47300
|
47334
|
47336
|
49083
|
56974
|
61059
|
61069
|
62038
|
65313
|
77301
|
78016
|
79959
|
80178
|
80179
|
80180
|
80181
|
80182
|
84400
|
86644
|
86645
|
87152
|
88128
|
95586
|
95716
|
97394
|
99026
|
99027
|
114217
|
114218
|
114219
|
114220
|
114221
|
114222
|
114223
|
114224
|
114225
|
114226
|
119255
|
121181
|
131891
|
131893
|
131894
|
134862
|
144109
|
144144
|
144671
|
144672
|
144673
|
147183
|
149030
|
149031
|
149032
|
149033
|
160566
|
160567
|
160568