Attachment 80002 Details for Bug 17776 – Bug 17776: (QA follow-up) Consistent regex for Plack detection

[patch] Bug 17776: (QA follow-up) Consistent regex for Plack detection

Bug-17776-QA-follow-up-Consistent-regex-for-Plack-.patch (text/plain), 1.29 KB, created by Marcel de Rooy on 2018-10-05 09:21:16 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Marcel de Rooy

Created: 2018-10-05 09:21:16 UTC

Size: 1.29 KB

patch

obsolete

>From 94a6ed7898e62a2d0b6bb8a339e4889b789e6df6 Mon Sep 17 00:00:00 2001
>From: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
>Date: Fri, 5 Oct 2018 10:25:43 +0200
>Subject: [PATCH] Bug 17776: (QA follow-up) Consistent regex for Plack
> detection
>Content-Type: text/plain; charset=utf-8
>
>Synchronizing:
>C4/Auth_with_shibboleth.pm:    if ( any { /(^psgi|^plack)/i } keys %ENV ) {
>Koha/AuthUtils.pm:    if ( ( any { /(^psgi\.|^plack\.)/i } keys %ENV ) && $ENV{SCRIPT_NAME} =~ m,^/(intranet|opac)(.*), ) {
>about.pl:if ( any { /(^psgi\.|^plack\.)/i } keys %ENV ) {
>
>Actually we should move it to a subroutine. New report please.
>
>Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
>---
> C4/Auth_with_shibboleth.pm | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/C4/Auth_with_shibboleth.pm b/C4/Auth_with_shibboleth.pm
>index dc18a1f..480d5d8 100644
>--- a/C4/Auth_with_shibboleth.pm
>+++ b/C4/Auth_with_shibboleth.pm
>@@ -84,7 +84,7 @@ sub get_login_shib {
> 
>     my $matchAttribute = $config->{mapping}->{ $config->{matchpoint} }->{is};
> 
>-    if ( any { /(^psgi|^plack)/i } keys %ENV ) {
>+    if ( any { /(^psgi\.|^plack\.)/i } keys %ENV ) {
>       $debug and warn $matchAttribute . " value: " . $ENV{"HTTP_".uc($matchAttribute)};
>       return $ENV{"HTTP_".uc($matchAttribute)} || '';
>     } else {
>-- 
>2.1.4

Actions: View | Diff | Splinter Review

Attachments on bug 17776: 60800 | 60847 | 61426 | 68216 | 79572 | 79573 | 80000 | 80001 | 80002 | 80003 | 80023 | 80024 | 80025 | 80026