Bugzilla – Attachment 80020 Details for
Bug 9968
Incorrect index used for 'Standard number' in advanced search
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 9968: Fix wrong index for Standard number in advanced and label search
Bug-9968-Fix-wrong-index-for-Standard-number-in-ad.patch (text/plain), 4.05 KB, created by
Marcel de Rooy
on 2018-10-05 10:21:31 UTC
(
hide
)
Description:
Bug 9968: Fix wrong index for Standard number in advanced and label search
Filename:
MIME Type:
Creator:
Marcel de Rooy
Created:
2018-10-05 10:21:31 UTC
Size:
4.05 KB
patch
obsolete
>From 1226d77e01d33e2887ce364b3bb9a82a09692323 Mon Sep 17 00:00:00 2001 >From: Katrin Fischer <katrin.fischer.83@web.de> >Date: Wed, 16 May 2018 01:05:07 +0000 >Subject: [PATCH] Bug 9968: Fix wrong index for Standard number in advanced and > label search >Content-Type: text/plain; charset=utf-8 > >'Standard number' indicates that you can search ISBN, ISSN and other >standard numbers, but we are using the wrong index and only get a >very limited search for biblionumber instead. > >This patch changes the index from sn to ident. > >To test: >- Check both staff and OPAC advanced search: > - Search for Standard number = ISBN > - Search for Standard number = ISSN > Both should work. > Toggle [Intranet|OPAC]NumbersPreferPhrase system preferences >- Check the label creator > - Add a new batch > - Use 'add items' option and search for Standard number > >Signed-off-by: Michal Denar <black23@gmail.com> > >Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> >--- > koha-tmpl/intranet-tmpl/prog/en/includes/search_indexes.inc | 4 ++-- > koha-tmpl/intranet-tmpl/prog/en/modules/labels/search.tt | 2 +- > koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-advsearch.tt | 4 ++-- > 3 files changed, 5 insertions(+), 5 deletions(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/includes/search_indexes.inc b/koha-tmpl/intranet-tmpl/prog/en/includes/search_indexes.inc >index 95d3684..1aff1a4 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/includes/search_indexes.inc >+++ b/koha-tmpl/intranet-tmpl/prog/en/includes/search_indexes.inc >@@ -23,9 +23,9 @@ > <option value="bc">Barcode</option> > <option value="location">Shelving location</option> > [% IF ( Koha.Preference('IntranetNumbersPreferPhrase') ) %] >- <option value="sn,phr">Standard number</option> >+ <option value="ident,phr">Standard number</option> > [% ELSE %] >- <option value="sn">Standard number</option> >+ <option value="ident">Standard number</option> > [% END %] > <option value="nb"> ISBN</option> > <option value="ns"> ISSN</option> >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/labels/search.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/labels/search.tt >index 4e7e25f..039b63c 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/labels/search.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/labels/search.tt >@@ -30,7 +30,7 @@ to add to Batch [% batch_id | html %] > [% IF idx == 'yr' %]<option value="yr" selected="selected">Publication date</option> > [% ELSE %]<option value="yr">Publication date</option>[% END %] > >-[% IF idx == 'sn' %]<option value="sn" selected="selected">Standard number</option> >+[% IF idx == 'sn' %]<option value="ident" selected="selected">Standard number</option> > [% ELSE %]<option value="sn">Standard number</option>[% END %] > > [% IF idx == 'nb' %]<option value="nb" selected="selected">ISBN</option> >diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-advsearch.tt b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-advsearch.tt >index 427f737..8cbc5a9 100644 >--- a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-advsearch.tt >+++ b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-advsearch.tt >@@ -82,9 +82,9 @@ > <option value="pl,wrdl">Publisher location</option> > [% IF ( expanded_options ) %] > [% IF ( Koha.Preference('OPACNumbersPreferPhrase') ) %] >- <option value="sn,phr">Standard number</option> >+ <option value="ident,phr">Standard number</option> > [% ELSE %] >- <option value="sn">Standard number</option> >+ <option value="ident">Standard number</option> > [% END %] > <option value="nb"> ISBN</option> > <option value="ns"> ISSN</option> >-- >2.1.4
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 9968
:
75351
|
79862
| 80020