Attachment 80082 Details for Bug 21500 – Bug 21500: Remove warnings in rotating collections

[patch] Bug 21500: Remove warnings in rotating collections

Bug-21500-Remove-warnings-in-rotating-collections.patch (text/plain), 1.44 KB, created by Tomás Cohen Arazi (tcohen) on 2018-10-05 13:25:01 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Tomás Cohen Arazi (tcohen)

Created: 2018-10-05 13:25:01 UTC

Size: 1.44 KB

patch

obsolete

>From 05bd37394947935bba02af70abd8e49f36cf6e73 Mon Sep 17 00:00:00 2001
>From: Tomas Cohen Arazi <tomascohen@theke.io>
>Date: Thu, 4 Oct 2018 14:08:32 -0300
>Subject: [PATCH] Bug 21500: Remove warnings in rotating collections
>
>To test:
>- Go to Tools > Rotating collections
>=> FAIL: Some warinings on the logs
>- Apply this patch
>- Reload page
>=> SUCCESS: No warinings
>- Sign off :-D
>
>Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
>---
> rotating_collections/addItems.pl | 5 +++--
> 1 file changed, 3 insertions(+), 2 deletions(-)
>
>diff --git a/rotating_collections/addItems.pl b/rotating_collections/addItems.pl
>index 7d4fd644bb..4c79328f3f 100755
>--- a/rotating_collections/addItems.pl
>+++ b/rotating_collections/addItems.pl
>@@ -41,7 +41,8 @@ my ( $template, $loggedinuser, $cookie ) = get_template_and_user(
>     }
> );
> 
>-if ( $query->param('action') eq 'addItem' ) {
>+if ( defined $query->param('action') and
>+     $query->param('action') eq 'addItem' ) {
>     ## Add the given item to the collection
>     my $colId      = $query->param('colId');
>     my $barcode    = $query->param('barcode');
>@@ -91,7 +92,7 @@ if ( $query->param('action') eq 'addItem' ) {
> }
> 
> my ( $colId, $colTitle, $colDescription, $colBranchcode ) =
>-  GetCollection( $query->param('colId') );
>+  GetCollection( scalar $query->param('colId') );
> my $collectionItems = GetItemsInCollection($colId);
> if ($collectionItems) {
>     $template->param( collectionItemsLoop => $collectionItems );
>-- 
>2.19.0

Actions: View | Diff | Splinter Review

Attachments on bug 21500: 80082 | 80125 | 80162