Bugzilla – Attachment 80123 Details for
Bug 20910
773$g not displayed if $0 is present
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 20910: Display 773$g when $0 is present too
Bug-20910-Display-773g-when-0-is-present-too.patch (text/plain), 4.88 KB, created by
Julian Maurice
on 2018-10-05 14:38:41 UTC
(
hide
)
Description:
Bug 20910: Display 773$g when $0 is present too
Filename:
MIME Type:
Creator:
Julian Maurice
Created:
2018-10-05 14:38:41 UTC
Size:
4.88 KB
patch
obsolete
>From 74b56a9ecb9d30be16389a7c3e27c6b7b89ac680 Mon Sep 17 00:00:00 2001 >From: Tomas Cohen Arazi <tomascohen@theke.io> >Date: Mon, 11 Jun 2018 11:34:22 -0300 >Subject: [PATCH] Bug 20910: Display 773$g when $0 is present too > >This patch makes the XSLT logic add the $g subfield in the 773 display >in both the OPAC and staff interface MARC21 record detail pages. > >The XSLT chooses between different ways to create the link for the >related content, but then it only adds the $g in two of the cases. >There's no obvious reason for a different display. > >To test: >- Have a record with: > >=773 $tHost title $gp4. > >=> SUCCESS: Notice the Detail view shows: > In: Host title p4. > >- Have another record with: > >=773 $tHost title $gp4. $w100 >- Enable UseControlNumber (only to cover the case): >=> SUCCESS: Notice the detail view shows > In: Host title p4. > >- Have another record with: > >=773 $tHost title $gp4. $0456 > >=> FAIL: The Detail view doesn't show p4. >- Apply this patch >- Reload >=> SUCCESS: The Detail view displays p4.! >- Sign off :-D > >Sponsored-by: Escuela de Orientacion Lacaniana >Signed-off-by: Jesse Maseto <jesse@bywatersolutions.com> >Signed-off-by: Julian Maurice <julian.maurice@biblibre.com> >--- > .../prog/en/xslt/MARC21slim2intranetDetail.xsl | 6 ++++-- > .../opac-tmpl/bootstrap/en/xslt/MARC21slim2OPACDetail.xsl | 5 +++-- > 2 files changed, 7 insertions(+), 4 deletions(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/xslt/MARC21slim2intranetDetail.xsl b/koha-tmpl/intranet-tmpl/prog/en/xslt/MARC21slim2intranetDetail.xsl >index 9727767dbb..c2c9cb953e 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/xslt/MARC21slim2intranetDetail.xsl >+++ b/koha-tmpl/intranet-tmpl/prog/en/xslt/MARC21slim2intranetDetail.xsl >@@ -957,7 +957,6 @@ > <a><xsl:attribute name="href">/cgi-bin/koha/catalogue/search.pl?q=Control-number:<xsl:call-template name="extractControlNumber"><xsl:with-param name="subfieldW" select="marc:subfield[@code='w']"/></xsl:call-template></xsl:attribute> > <xsl:value-of select="translate($f773, '()', '')"/> > </a> >- <xsl:if test="marc:subfield[@code='g']"><xsl:text> </xsl:text><xsl:value-of select="marc:subfield[@code='g']"/></xsl:if> > </xsl:when> > <xsl:when test="marc:subfield[@code='0']"> > <a><xsl:attribute name="href">/cgi-bin/koha/catalogue/detail.pl?biblionumber=<xsl:value-of select="marc:subfield[@code='0']"/></xsl:attribute> >@@ -968,9 +967,12 @@ > <a><xsl:attribute name="href">/cgi-bin/koha/catalogue/search.pl?q=ti,phr:<xsl:value-of select="translate($f773, '()', '')"/></xsl:attribute> > <xsl:value-of select="$f773"/> > </a> >- <xsl:if test="marc:subfield[@code='g']"><xsl:text> </xsl:text><xsl:value-of select="marc:subfield[@code='g']"/></xsl:if> > </xsl:otherwise> > </xsl:choose> >+ <xsl:if test="marc:subfield[@code='g']"> >+ <xsl:text> </xsl:text><xsl:value-of select="marc:subfield[@code='g']"/> >+ </xsl:if> >+ > </span> > > <xsl:if test="marc:subfield[@code='n']"> >diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/xslt/MARC21slim2OPACDetail.xsl b/koha-tmpl/opac-tmpl/bootstrap/en/xslt/MARC21slim2OPACDetail.xsl >index 9e23047060..196d709bc1 100644 >--- a/koha-tmpl/opac-tmpl/bootstrap/en/xslt/MARC21slim2OPACDetail.xsl >+++ b/koha-tmpl/opac-tmpl/bootstrap/en/xslt/MARC21slim2OPACDetail.xsl >@@ -1062,7 +1062,6 @@ > <a><xsl:attribute name="href">/cgi-bin/koha/opac-search.pl?q=Control-number:<xsl:call-template name="extractControlNumber"><xsl:with-param name="subfieldW" select="marc:subfield[@code='w']"/></xsl:call-template></xsl:attribute> > <xsl:value-of select="translate($f773, '()', '')"/> > </a> >- <xsl:if test="marc:subfield[@code='g']"><xsl:text> </xsl:text><xsl:value-of select="marc:subfield[@code='g']"/></xsl:if> > </xsl:when> > <xsl:when test="marc:subfield[@code='0']"> > <a><xsl:attribute name="href">/cgi-bin/koha/opac-detail.pl?biblionumber=<xsl:value-of select="marc:subfield[@code='0']"/></xsl:attribute> >@@ -1073,9 +1072,11 @@ > <a><xsl:attribute name="href">/cgi-bin/koha/opac-search.pl?q=ti,phr:<xsl:value-of select="translate($f773, '()', '')"/></xsl:attribute> > <xsl:value-of select="$f773"/> > </a> >- <xsl:if test="marc:subfield[@code='g']"><xsl:text> </xsl:text><xsl:value-of select="marc:subfield[@code='g']"/></xsl:if> > </xsl:otherwise> > </xsl:choose> >+ <xsl:if test="marc:subfield[@code='g']"> >+ <xsl:text> </xsl:text><xsl:value-of select="marc:subfield[@code='g']"/> >+ </xsl:if> > </span> > > <xsl:if test="marc:subfield[@code='n']"> >-- >2.17.1
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 20910
:
75960
|
75961
|
78741
|
78742
| 80123 |
80124