Bugzilla – Attachment 80139 Details for
Bug 18421
Make Coce cover images available for staff search
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 18421: (follow-up) Adding missing filters
Bug-18421-follow-up-Adding-missing-filters.patch (text/plain), 5.34 KB, created by
Owen Leonard
on 2018-10-05 15:24:04 UTC
(
hide
)
Description:
Bug 18421: (follow-up) Adding missing filters
Filename:
MIME Type:
Creator:
Owen Leonard
Created:
2018-10-05 15:24:04 UTC
Size:
5.34 KB
patch
obsolete
>From 0e7e1754468bde357b2d5bca408a5a1439db6c07 Mon Sep 17 00:00:00 2001 >From: Owen Leonard <oleonard@myacpl.org> >Date: Fri, 5 Oct 2018 15:14:57 +0000 >Subject: [PATCH] Bug 18421: (follow-up) Adding missing filters > >This patch adds template filters as prompted by the QA tool. >--- > koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/detail.tt | 12 ++++++------ > koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/results.tt | 8 ++++---- > 2 files changed, 10 insertions(+), 10 deletions(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/detail.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/detail.tt >index c0bad8a..dd5aace 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/detail.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/detail.tt >@@ -149,9 +149,9 @@ > [% END %] > [% IF ( IntranetCoce && CoceProviders ) %] > [% coce_id = normalized_ean || normalized_isbn %] >- <a class="p1" href="/cgi-bin/koha/catalogue/[% DetailPage %]?biblionumber=[% biblionumber |url %]"> >+ <a class="p1" href="/cgi-bin/koha/catalogue/[% DetailPage | html %]?biblionumber=[% biblionumber | url %]"> > [% IF ( coce_id ) %] >- <span style="block" title="[% biblionumber |url %]" class="[% coce_id %]" id="coce-thumbnail-preview"></span> >+ <span style="block" title="[% biblionumber | url %]" class="[% coce_id | html %]" id="coce-thumbnail-preview"></span> > [% ELSE %] > <span class="no-image">No cover image available</span> > [% END %] >@@ -234,9 +234,9 @@ > [% END %] > [% IF ( IntranetCoce && CoceProviders ) %] > [% coce_id = normalized_ean || normalized_isbn %] >- <a class="p1" href="/cgi-bin/koha/catalogue/[% DetailPage %]?biblionumber=[% biblionumber |url %]"> >+ <a class="p1" href="/cgi-bin/koha/catalogue/[% DetailPage | html %]?biblionumber=[% biblionumber | url %]"> > [% IF ( coce_id ) %] >- <span style="block" title="[% biblionumber |url %]" class="[% coce_id %]" id="coce-thumbnail-preview"></span> >+ <span style="block" title="[% biblionumber | url %]" class="[% coce_id | html %]" id="coce-thumbnail-preview"></span> > [% ELSE %] > <span class="no-image">No cover image available</span> > [% END %] >@@ -918,7 +918,7 @@ > [% INCLUDE 'catalog-strings.inc' %] > [% Asset.js("js/catalog.js") | $raw %] > [% INCLUDE 'greybox.inc' %] >- [% Asset.js("js/coce.js") %] >+ [% Asset.js("js/coce.js") | $raw %] > <script type="text/javascript"> > // http://www.oreillynet.com/pub/a/javascript/2003/10/21/amazonhacks.html > function verify_images() { >@@ -1075,7 +1075,7 @@ > KOHA.LocalCover.GetCoverFromBibnumber(true); > [% END %] > [% IF ( IntranetCoce && CoceProviders ) %] >- KOHA.coce.getURL('[% CoceHost %]', '[% CoceProviders %]'); >+ KOHA.coce.getURL('[% CoceHost | html %]', '[% CoceProviders | html %]'); > [% END %] > > $("body").on("click",".previewMARC", function(e){ >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/results.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/results.tt >index cb8645f..71c8232 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/results.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/results.tt >@@ -384,9 +384,9 @@ > [% END %] > [% IF ( IntranetCoce && CoceProviders ) %] > [% coce_id = SEARCH_RESULT.normalized_ean || SEARCH_RESULT.normalized_isbn %] >- <a class="p1" href="/cgi-bin/koha/catalogue/[% DetailPage %]?biblionumber=[% SEARCH_RESULT.biblionumber |url %]"> >+ <a class="p1" href="/cgi-bin/koha/catalogue/[% DetailPage | html %]?biblionumber=[% SEARCH_RESULT.biblionumber | url %]"> > [% IF ( coce_id ) %] >- <span style="block" title="[% SEARCH_RESULT.biblionumber |url %]" class="[% coce_id %]" id="coce-thumbnail[% loop.count %]"></span> >+ <span style="block" title="[% SEARCH_RESULT.biblionumber | url %]" class="[% coce_id | html %]" id="coce-thumbnail[% loop.count | html %]"></span> > [% ELSE %] > <span class="no-image">No cover image available</span> > [% END %] >@@ -643,7 +643,7 @@ > [% Asset.js("js/browser.js") | $raw %] > [% Asset.js("lib/jquery/plugins/jquery.fixFloat.js") | $raw %] > [% Asset.js("lib/jquery/plugins/jquery.checkboxes.min.js") | $raw %] >- [% Asset.js("js/coce.js") %] >+ [% Asset.js("js/coce.js") | $raw %] > <script type="text/javascript"> > var MSG_NO_ITEM_SELECTED = _("Nothing is selected."); > var MSG_NON_RESERVES_SELECTED = _("One or more selected items cannot be placed on hold."); >@@ -770,7 +770,7 @@ > [% END %] > > [% IF ( IntranetCoce && CoceProviders ) %] >- KOHA.coce.getURL('[% CoceHost %]', '[% CoceProviders %]'); >+ KOHA.coce.getURL('[% CoceHost | html %]', '[% CoceProviders | html %]'); > [% END %] > > $("#select_all").on("click",function(e){ >-- >2.1.4
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 18421
:
71322
|
71977
|
72772
|
73401
|
73495
|
74252
|
77597
|
77598
|
77599
|
77764
|
77765
|
80137
|
80138
|
80139
|
83633
|
83634
|
83635
|
83636
|
91552
|
91553
|
91554
|
91555
|
91786
|
91787
|
91788
|
91789
|
93654
|
93655
|
93656
|
93657