Attachment 80223 Details for Bug 21456 – Bug 21456: The 'New authority' button lists authority types inconsistently

[patch] Bug 21456: The 'New authority' button lists authority types inconsistently

Bug-21456-The-New-authority-button-lists-authority.patch (text/plain), 1.52 KB, created by Martin Renvoize (ashimema) on 2018-10-08 14:27:39 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Martin Renvoize (ashimema)

Created: 2018-10-08 14:27:39 UTC

Size: 1.52 KB

patch

obsolete

>From fd1ff5df2066d1ef0193d71f2bb2ed206dad6758 Mon Sep 17 00:00:00 2001
>From: Andreas Roussos <arouss1980@gmail.com>
>Date: Sun, 30 Sep 2018 13:06:28 +0300
>Subject: [PATCH] Bug 21456: The 'New authority' button lists authority types
> inconsistently
>
>The 'New authority' button does not always list the available
>authority types in A-Z order based on their description.
>
>This patch fixes that.
>
>Test plan:
>1) Go to Home > Authorities in the staff client; notice how the
>   'New authority' button lists auth types sorted by description.
>2) Go to an authority's detail page; notice how the same 'New
>   authority' button will list auth types sorted by their code.
>3) Apply the patch.
>4) In an authority's detail page, the 'New authority' button will
>   now list the available authority types sorted by description.
>
>Signed-off-by: Michal Denar <black23@gmail.com>
>Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
>---
> authorities/detail.pl | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/authorities/detail.pl b/authorities/detail.pl
>index 908b7bdbb5..0e7ba42c77 100755
>--- a/authorities/detail.pl
>+++ b/authorities/detail.pl
>@@ -188,7 +188,7 @@ my $authtypecode = $authobj ? $authobj->authtypecode : q{};
> $tagslib = &GetTagsLabels(1,$authtypecode);
> 
> # Build list of authtypes for showing them
>-my $authority_types = Koha::Authority::Types->search({}, { order_by => ['authtypecode']});
>+my $authority_types = Koha::Authority::Types->search({}, { order_by => ['authtypetext']});
> 
> my $record=GetAuthority($authid);
> 
>-- 
>2.19.0

Actions: View | Diff | Splinter Review

Attachments on bug 21456: 79653 | 79654 | 79655 | 79661 | 80223 | 80224