Attachment 80242 Details for Bug 16420 – Bug 16420: Buttons inconsistent between "Hold found" and "Hold found (waiting)" dialogs in checkin

[patch] Bug 16420: Buttons inconsistent between "Hold found" and "Hold found (waiting)" dialogs in checkin

Bug-16420-Buttons-inconsistent-between-Hold-found-.patch (text/plain), 2.74 KB, created by Chris Cormack on 2018-10-08 22:27:13 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Chris Cormack

Created: 2018-10-08 22:27:13 UTC

Size: 2.74 KB

patch

obsolete

>From 56080496f37d1cbf4d59fbd9d8b5869017f85db1 Mon Sep 17 00:00:00 2001
>From: Owen Leonard <oleonard@myacpl.org>
>Date: Fri, 5 Oct 2018 17:05:19 +0000
>Subject: [PATCH] Bug 16420: Buttons inconsistent between "Hold found" and
> "Hold found (waiting)" dialogs in checkin
>
>This patch makes minor changes to the text of hold confirmation buttons
>in the checkin process in order to make them more consistent.
>
>Also changed: Removed the "danger" class from the "Ignore" button for
>readability and consistency's sake.
>
>To test, apply the patch and check in an item which is on hold for a
>patron at your logged-in library. The hold confirmation dialog's buttons
>should read "Confirm hold," "Print slip and confirm," and "Ignore."
>
>Confirm the hold, then check in the same item again.
>
>In the dialog, the buttons should read "Confirm hold," "Print slip and
>confirm," and "Cancel hold."
>
>Signed-off-by: Michal Denar <black23@gmail.com>
>Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
>---
> koha-tmpl/intranet-tmpl/prog/en/modules/circ/returns.tt | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/circ/returns.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/circ/returns.tt
>index 0bfc871153..5763e97bdc 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/circ/returns.tt
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/circ/returns.tt
>@@ -276,12 +276,12 @@
>                     <input type="hidden" name="cancel_reserve" value="0" />
> 
>                     <button type="submit" class="btn btn-default approve" data-dismiss="modal">
>-                        <i class="fa fa-check"></i> Confirm
>+                        <i class="fa fa-check"></i> Confirm hold
>                     </button>
> 
>                     <input type="hidden" name="print_slip" value="0" />
>                     <button type="submit" class="btn btn-default print" onclick="this.form.print_slip.value = 1; this.form.submit();">
>-                        <i class="fa fa-print"></i> Print and confirm
>+                        <i class="fa fa-print"></i> Print slip and confirm
>                     </button>
> 
>                     <button type="submit" class="btn btn-default deny" onclick="this.form.cancel_reserve.value = 1; this.form.submit();">
>@@ -497,7 +497,7 @@
>                         </button>
>                     [% END %]
> 
>-                    <button data-dismiss="modal" aria-hidden="true" type="submit" class="btn btn-danger deny" onclick="$('#barcode').focus(); return false;">
>+                    <button data-dismiss="modal" aria-hidden="true" type="submit" class="btn btn-default deny" onclick="$('#barcode').focus(); return false;">
>                         <i class="fa fa-times"></i> Ignore
>                     </button>
>                 </div>
>-- 
>2.19.1

Actions: View | Diff | Splinter Review

Attachments on bug 16420: 80144 | 80145 | 80242