Attachment 80244 Details for Bug 20548 – Bug 20548: (follow-up) Fix unit tests

[patch] Bug 20548: (follow-up) Fix unit tests

Bug-20548-follow-up-Fix-unit-tests.patch (text/plain), 1.90 KB, created by Chris Cormack on 2018-10-08 23:42:23 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Chris Cormack

Created: 2018-10-08 23:42:23 UTC

Size: 1.90 KB

patch

obsolete

>From dbcd5886313bf9c92b80d3aa67fd2675f83ca150 Mon Sep 17 00:00:00 2001
>From: Andrew Isherwood <andrew.isherwood@ptfs-europe.com>
>Date: Wed, 26 Sep 2018 14:04:00 +0100
>Subject: [PATCH] Bug 20548: (follow-up) Fix unit tests
>
>Removed the "Backend create: copyright clearance" unit test since we no
>longer have a "copyrightclearance" stage, hence we don't have a block in
>the template handling it, hence the test failure!
>
>Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
>---
> t/db_dependent/Illrequests.t | 17 +----------------
> 1 file changed, 1 insertion(+), 16 deletions(-)
>
>diff --git a/t/db_dependent/Illrequests.t b/t/db_dependent/Illrequests.t
>index 761de9f12b..76de8fa1fb 100644
>--- a/t/db_dependent/Illrequests.t
>+++ b/t/db_dependent/Illrequests.t
>@@ -359,7 +359,7 @@ subtest 'Backend testing (mocks)' => sub {
> 
> subtest 'Backend core methods' => sub {
> 
>-    plan tests => 18;
>+    plan tests => 17;
> 
>     $schema->storage->txn_begin;
> 
>@@ -407,21 +407,6 @@ subtest 'Backend core methods' => sub {
>                          { stage => 'bar', method => 'create' },
>                          { stage => 'commit', method => 'create' },
>                          { stage => 'commit', method => 'create' });
>-    # Test Copyright Clearance
>-    t::lib::Mocks::mock_preference("ILLModuleCopyrightClearance", "Test Copyright Clearance.");
>-    is_deeply($illrq->backend_create({test => 1}),
>-              {
>-                  error   => 0,
>-                  status  => '',
>-                  message => '',
>-                  method  => 'create',
>-                  stage   => 'copyrightclearance',
>-                  value   => {
>-                      backend => "Mock"
>-                  }
>-              },
>-              "Backend create: copyright clearance.");
>-    t::lib::Mocks::mock_preference("ILLModuleCopyrightClearance", "");
>     # Test non-commit
>     is_deeply($illrq->backend_create({test => 1}),
>               {
>-- 
>2.19.1

Actions: View | Diff | Splinter Review

Attachments on bug 20548: 73871 | 74155 | 74549 | 79051 | 79414 | 80243 | 80244