Attachment 80254 Details for Bug 21513 – Bug 21513: Add a 'Cancel' button to the authority editor and remove duplicate 'Save' button

[patch] Bug 21513: Add a 'Cancel' button to the authority editor and remove duplicate 'Save' button

Bug-21513-Add-a-Cancel-button-to-the-authority-edi.patch (text/plain), 2.75 KB, created by Martin Renvoize (ashimema) on 2018-10-09 09:41:47 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Martin Renvoize (ashimema)

Created: 2018-10-09 09:41:47 UTC

Size: 2.75 KB

patch

obsolete

>From 0a3f008073d5b8f5a179d9f5f0a0d1bbc70dc331 Mon Sep 17 00:00:00 2001
>From: Andreas Roussos <arouss1980@gmail.com>
>Date: Sun, 7 Oct 2018 21:00:09 +0300
>Subject: [PATCH] Bug 21513: Add a 'Cancel' button to the authority editor and
> remove duplicate 'Save' button
>
>The authority editor (authorities/authorities.pl) does not have
>a 'Cancel' button. Also, it has two 'Save' buttons.
>
>This patch fixes that by:
>a) adding a 'Cancel' button to the floating toolbar at the top
>b) removing the 'Save' button from the bottom of the page
>
>Test plan:
>1) Go to Home > Authorities and launch the authority editor by
>   clicking on 'New authority'. Notice how the editor doesn't
>   have a 'Cancel' button. Also notice the two 'Save' buttons.
>2) Apply the patch.
>3) Re-launch the authority editor, and hit cancel; you should
>   be taken back to Home > Authorities.
>4) Edit an existing authority, and hit cancel; you should be
>   taken back to the details page for the authority you chose.
>5) Edit an authority as new (duplicate), and hit cancel; you
>   should be taken back to Home > Authorities (this behaviour
>   is mimicking the bibliographic editor: when duplicating a
>   biblio the 'Cancel' button will take you back to Home >
>   Cataloging).
>
>Signed-off-by: Michal Denar <black23@gmail.com>
>Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
>---
> .../prog/en/modules/authorities/authorities.tt        | 11 +++++++----
> 1 file changed, 7 insertions(+), 4 deletions(-)
>
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/authorities/authorities.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/authorities/authorities.tt
>index 032761fc14..fd6119641f 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/authorities/authorities.tt
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/authorities/authorities.tt
>@@ -216,6 +216,13 @@ function confirmnotdup(redirect){
>         <div class="btn-group">
>             <a class="btn btn-default btn-sm" id="z3950submit" href="#"><i class="fa fa-search"></i> Z39.50 search</a>
>         </div>
>+        <div class="btn-group">
>+            [% IF ( authid ) %]
>+                <a class="btn btn-default btn-sm" id="cancel" href="/cgi-bin/koha/authorities/detail.pl?authid=[% authid | url %]">Cancel</a>
>+            [% ELSE %]
>+                <a class="btn btn-default btn-sm" id="cancel" href="/cgi-bin/koha/authorities/authorities-home.pl">Cancel</a>
>+            [% END %]
>+        </div>
>     </div>
> 
> <div id="authoritytabs" class="toptabs numbered">
>@@ -426,10 +433,6 @@ function confirmnotdup(redirect){
>     <input type="hidden" name="field_value" value="[% authtypecode | html %]" />
> [% END %]
> 
>-<fieldset class="action">
>-        <input type="button" id="addauth2" value="Save" onclick="Check(this.form)" accesskey="w" />
>-</fieldset>
>-
> </form>
> 
> </div>
>-- 
>2.19.0

Actions: View | Diff | Splinter Review

Attachments on bug 21513: 80175 | 80176 | 80177 | 80254