Attachment 80255 Details for Bug 21320 – Bug 21320: Holds to pull should honor syspref AllowHoldsOnDamagedItems

[patch] Bug 21320: Holds to pull should honor syspref AllowHoldsOnDamagedItems

Bug-21320-Holds-to-pull-should-honor-syspref-Allow.patch (text/plain), 1.61 KB, created by Martin Renvoize (ashimema) on 2018-10-09 10:05:14 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Martin Renvoize (ashimema)

Created: 2018-10-09 10:05:14 UTC

Size: 1.61 KB

patch

obsolete

>From b1ff69595a84e28ec6d9b52ae38deff14e9bbfc7 Mon Sep 17 00:00:00 2001
>From: Dobrica Pavlinusic <dpavlin@rot13.org>
>Date: Thu, 6 Sep 2018 13:21:53 +0200
>Subject: [PATCH] Bug 21320: Holds to pull should honor syspref
> AllowHoldsOnDamagedItems
>
>Test plan:
>
>1. Set syspref AllowHoldsOnDamagedItems to Allow
>2. Create a hold on record with item which is damaged
>3. Verify that it doesn't appear in report
>4. Apply patch and verify that it's now visible
>
>Signed-off-by: Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com>
>Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
>---
> circ/pendingreserves.pl | 7 ++++++-
> 1 file changed, 6 insertions(+), 1 deletion(-)
>
>diff --git a/circ/pendingreserves.pl b/circ/pendingreserves.pl
>index 7f03d88cc1..734b8d7b94 100755
>--- a/circ/pendingreserves.pl
>+++ b/circ/pendingreserves.pl
>@@ -170,6 +170,11 @@ if ($enddate_iso) {
> 
> my $item_type = C4::Context->preference('item-level_itypes') ? "items.itype" : "biblioitems.itemtype";
> 
>+# Bug 21320
>+if ( ! C4::Context->preference('AllowHoldsOnDamagedItems') ) {
>+    $sqldatewhere .= " AND damaged = 0";
>+}
>+
> my $strsth =
>     "SELECT min(reservedate) as l_reservedate,
>             reserves.reserve_id,
>@@ -214,7 +219,7 @@ my $strsth =
>     AND issues.itemnumber IS NULL
>     AND reserves.priority <> 0 
>     AND reserves.suspend = 0
>-    AND notforloan = 0 AND damaged = 0 AND itemlost = 0 AND withdrawn = 0
>+    AND notforloan = 0 AND itemlost = 0 AND withdrawn = 0
>     ";
>     # GROUP BY reserves.biblionumber allows only items that are not checked out, else multiples occur when 
>     #    multiple patrons have a hold on an item
>-- 
>2.19.0

Actions: View | Diff | Splinter Review

Attachments on bug 21320: 78471 | 78472 | 80255