Bugzilla – Attachment 80258 Details for
Bug 15734
Audio Alerts broken
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
[ALTERNATIVE-PATCH] Bug 15734: Use To.json to filter audio alerts
Bug-15734-Use-Tojson-to-filter-audio-alerts.patch (text/plain), 1.46 KB, created by
Jonathan Druart
on 2018-10-09 13:49:00 UTC
(
hide
)
Description:
[ALTERNATIVE-PATCH] Bug 15734: Use To.json to filter audio alerts
Filename:
MIME Type:
Creator:
Jonathan Druart
Created:
2018-10-09 13:49:00 UTC
Size:
1.46 KB
patch
obsolete
>From bb01f37721cee2872f6b2e171be85eb13549f9a7 Mon Sep 17 00:00:00 2001 >From: Jonathan Druart <jonathan.druart@bugs.koha-community.org> >Date: Tue, 9 Oct 2018 10:47:11 -0300 >Subject: [PATCH] Bug 15734: Use To.json to filter audio alerts > >Test Plan: >1) Enable audio alerts >2) Note audio alerts don't work >3) Apply this patch >4) Note audio alerts now work > >Use complex selectors to test: > #circ_returns p.problem:contains('Not checked out.') > #doc3 > #bd >--- > koha-tmpl/intranet-tmpl/prog/en/includes/js_includes.inc | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/includes/js_includes.inc b/koha-tmpl/intranet-tmpl/prog/en/includes/js_includes.inc >index 046c7d525d..6c02936bef 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/includes/js_includes.inc >+++ b/koha-tmpl/intranet-tmpl/prog/en/includes/js_includes.inc >@@ -1,6 +1,7 @@ > [% USE raw %] > [% USE Asset %] > [% USE AudioAlerts %] >+[% USE To %] > [%# Prevent XFS attacks -%] > [% UNLESS popup %] > <script type="text/javascript"> >@@ -70,7 +71,7 @@ > <script type="text/javascript"> > //<![CDATA[ > var AUDIO_ALERT_PATH = '[% interface | html %]/[% theme | html %]/sound/'; >- var AUDIO_ALERTS = JSON.parse( '[% AudioAlerts.AudioAlerts | replace( "'", "\\'" ) | replace( '"', '\\"' ) | html %]' ); >+ var AUDIO_ALERTS = JSON.parse( "[% To.json(AudioAlerts.AudioAlerts) | $raw %]" ); > //]]> > > $( document ).ready(function() { >-- >2.11.0
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 15734
:
47620
|
47621
|
47644
|
47735
|
79997
|
79998
|
80052
|
80053
|
80056
|
80057
|
80164
|
80165
|
80258
|
80259
|
80277