Attachment 80281 Details for Bug 20581 – Bug 20581: API provide status_alias embed

[patch] Bug 20581: API provide status_alias embed

Bug-20581-API-provide-statusalias-embed.patch (text/plain), 2.68 KB, created by Andrew Isherwood on 2018-10-09 14:36:34 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Andrew Isherwood

Created: 2018-10-09 14:36:34 UTC

Size: 2.68 KB

patch

obsolete

>From 5859dd342e2c6aa36ea10412eece99edb67a3a17 Mon Sep 17 00:00:00 2001
>From: Andrew Isherwood <andrew.isherwood@ptfs-europe.com>
>Date: Tue, 17 Apr 2018 12:00:15 +0100
>Subject: [PATCH] Bug 20581: API provide status_alias embed
>
>- This patch provides the illrequests API route with an additional embed,
>called 'status_alias'. Requesting this embed returns an object for the
>request's status_alias authorised value, or null if one is not set.
>- This patch also adds the new status_alias as a default embed on the API
>call made by the illlist view
>
>Signed-off-by: Niamh.Walker-Headon@it-tallaght.ie
>---
> Koha/Illrequest.pm                                          | 5 +++++
> api/v1/swagger/paths/illrequests.json                       | 1 +
> koha-tmpl/intranet-tmpl/prog/en/modules/ill/ill-requests.tt | 2 +-
> 3 files changed, 7 insertions(+), 1 deletion(-)
>
>diff --git a/Koha/Illrequest.pm b/Koha/Illrequest.pm
>index d2c70ba64a..62b3b8e783 100644
>--- a/Koha/Illrequest.pm
>+++ b/Koha/Illrequest.pm
>@@ -1030,6 +1030,11 @@ sub TO_JSON {
>     $object->{id_prefix} = $self->id_prefix;
> 
>     if ( scalar (keys %$embed) ) {
>+        # Augment the request response with statusalias details if
>+        # appropriate
>+        if ( $embed->{status_alias}) {
>+            $object->{status_alias} = $self->statusalias;
>+        }
>         # Augment the request response with patron details if appropriate
>         if ( $embed->{patron} ) {
>             my $patron = $self->patron;
>diff --git a/api/v1/swagger/paths/illrequests.json b/api/v1/swagger/paths/illrequests.json
>index 13ec426fce..73cf46862f 100644
>--- a/api/v1/swagger/paths/illrequests.json
>+++ b/api/v1/swagger/paths/illrequests.json
>@@ -14,6 +14,7 @@
>                 "items": {
>                     "type": "string",
>                     "enum": [
>+                        "status_alias",
>                         "patron",
>                         "library",
>                         "capabilities",
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/ill/ill-requests.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/ill/ill-requests.tt
>index b188945d12..465c25d438 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/ill/ill-requests.tt
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/ill/ill-requests.tt
>@@ -220,7 +220,7 @@
>         // Get our data from the API and process it prior to passing
>         // it to datatables
>         var ajax = $.ajax(
>-            '/api/v1/illrequests?embed=metadata,patron,capabilities,library'
>+            '/api/v1/illrequests?embed=metadata,patron,capabilities,library,status_alias'
>             ).done(function() {
>                 var data = JSON.parse(ajax.responseText);
>                 // Make a copy, we'll be removing columns next and need
>-- 
>2.11.0

Actions: View | Diff | Splinter Review

Attachments on bug 20581: 74323 | 74324 | 74325 | 74326 | 74327 | 74362 | 75333 | 75334 | 75810 | 77819 | 77820 | 77821 | 77822 | 77823 | 77824 | 77825 | 77826 | 78376 | 78377 | 78378 | 78379 | 78380 | 78381 | 78382 | 78383 | 78384 | 78431 | 78515 | 78516 | 78517 | 78518 | 78519 | 78520 | 78521 | 78522 | 78523 | 80279 | 80280 | 80281 | 80282 | 80283 | 80284 | 80285 | 80286 | 80474 | 80475 | 80501 | 80503 | 80505 | 80598 | 80599 | 80600 | 82063 | 82064 | 82065 | 82066 | 82067 | 82068 | 82069 | 82070 | 82071 | 82072 | 82073 | 82074 | 82075 | 82076 | 82443 | 82444 | 82445 | 82446 | 82447 | 82448 | 82449 | 82450 | 82451 | 82452 | 82453 | 82454 | 82455 | 82456 | 82457 | 82458 | 82459 | 82460 | 82461 | 82462 | 82463 | 82464 | 82465 | 82466 | 82467 | 82468 | 82472 | 82483 | 82484 | 82485 | 82486 | 82487 | 82488 | 82489 | 82490 | 82491 | 82492 | 82493 | 82494 | 82495 | 82496 | 82733 | 84202 | 84404 | 84768 | 84770 | 84771 | 84772 | 84773 | 84774 | 84775 | 84776 | 84777 | 84778 | 84779 | 84780 | 84781 | 84782 | 84783 | 84784 | 84785 | 84791 | 84814 | 84818 | 84819 | 84844 | 84911 | 84912 | 84913 | 84914 | 84915 | 84916 | 84917 | 84918 | 84919 | 84920 | 84921 | 84922 | 84923 | 84924 | 84925 | 84926 | 84927 | 84928 | 84929 | 84930 | 84931 | 84964 | 85075 | 85076 | 85077 | 85078 | 85079 | 85080 | 85081 | 85082 | 85083 | 85084 | 85085 | 85086 | 85087 | 85088 | 85089 | 85090 | 85091 | 85092 | 85093 | 85094 | 85095 | 85096