Bugzilla – Attachment 80294 Details for
Bug 21174
Change default behavior to open OPAC cart in one click
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 21174: Removed MSG_IN_YOUR_CART and its usage in OPAC JS
Bug-21174-Removed-MSGINYOURCART-and-its-usage-in-O.patch (text/plain), 2.23 KB, created by
Jonathan Druart
on 2018-10-09 16:39:40 UTC
(
hide
)
Description:
Bug 21174: Removed MSG_IN_YOUR_CART and its usage in OPAC JS
Filename:
MIME Type:
Creator:
Jonathan Druart
Created:
2018-10-09 16:39:40 UTC
Size:
2.23 KB
patch
obsolete
>From 67ea3251ea27306a7c7553f4a5cd5e09fb20a887 Mon Sep 17 00:00:00 2001 >From: Alex Buckley <alexbuckley@catalyst.net.nz> >Date: Sun, 30 Sep 2018 16:22:10 +0000 >Subject: [PATCH] Bug 21174: Removed MSG_IN_YOUR_CART and its usage in OPAC JS > >The 'Items in your cart' message is obsolete with the cart dropdown >box being removed. > >Therefore the assignment of this text into the >MSG_IN_YOUR_CART variable (which is done in the opac-bottom.inc), and >the use of the MSG_IN_YOUR_CART variable in the updateBasket() function >(in the OPAC's basket.js) has been removed. > >Sponsored-By: Toi Ohomai Institute of Technology, New Zealand > >Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> >--- > koha-tmpl/opac-tmpl/bootstrap/en/includes/opac-bottom.inc | 1 - > koha-tmpl/opac-tmpl/bootstrap/js/basket.js | 2 -- > 2 files changed, 3 deletions(-) > >diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/includes/opac-bottom.inc b/koha-tmpl/opac-tmpl/bootstrap/en/includes/opac-bottom.inc >index 6baedf9835..20d92f78d9 100644 >--- a/koha-tmpl/opac-tmpl/bootstrap/en/includes/opac-bottom.inc >+++ b/koha-tmpl/opac-tmpl/bootstrap/en/includes/opac-bottom.inc >@@ -156,7 +156,6 @@ $.widget.bridge('uitooltip', $.ui.tooltip); > var MSG_CONFIRM_DEL_BASKET = _("Are you sure you want to empty your cart?"); > var MSG_CONFIRM_DEL_RECORDS = _("Are you sure you want to remove the selected items?"); > var MSG_ITEM_IN_CART = _("In your cart"); >- var MSG_IN_YOUR_CART = _("Items in your cart: "); > var MSG_ITEM_NOT_IN_CART = _("Add to your cart"); > [% END %] > [% IF ( Koha.Preference( 'opacuserlogin' ) == 1 ) && ( Koha.Preference( 'TagsEnabled' ) == 1 ) %] >diff --git a/koha-tmpl/opac-tmpl/bootstrap/js/basket.js b/koha-tmpl/opac-tmpl/bootstrap/js/basket.js >index 03e8e9e9b9..c642f947bc 100644 >--- a/koha-tmpl/opac-tmpl/bootstrap/js/basket.js >+++ b/koha-tmpl/opac-tmpl/bootstrap/js/basket.js >@@ -410,10 +410,8 @@ function updateBasket(updated_value,target) { > } > if(target){ > target.$('#basketcount').html(bcount); >- target.$('.cart-message').html(MSG_IN_YOUR_CART+updated_value); > } else { > $('#basketcount').html(bcount); >- $('.cart-message').html(MSG_IN_YOUR_CART+updated_value); > } > } > >-- >2.11.0
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 21174
:
77550
|
77642
|
77684
|
78006
|
78007
|
78008
|
78009
|
78010
|
79647
|
79714
|
79856
|
80293
|
80294
|
80295
|
80373
|
80374
|
80375